Gaëtan Maisse
b0e1d93eca
refactor: create a executeCommand function and use it for every yarn or npm calls
...
It move the `spawnSync` usage to only a single place which is simpler to maintain.
It also simplify testing as there is no more need to mock an external dep
2020-06-09 08:19:11 +02:00
Gaëtan Maisse
f5c788b92b
refactor: update signature of runAddDeps function
2020-06-08 20:08:17 +02:00
Gaëtan Maisse
0c1a9740dc
refactor: update signature of runInstall function
2020-06-08 20:08:16 +02:00
Gaëtan Maisse
94620167cc
refactor: create function to add SB command in scripts attribute of package.json
2020-06-08 20:08:16 +02:00
Gaëtan Maisse
41dc95791b
refactor: move PackageJson.ts inside js-package-manager directory
2020-06-08 20:08:15 +02:00
Gaëtan Maisse
d4000030c3
refactor: remove usage of has_yarn
2020-06-08 20:08:15 +02:00
Gaëtan Maisse
2912bcbefe
refactor: remove unneeded params and variables
...
All this variables were used to check if user was running Yarn and do this accordingly.
Now we use the factory to get the "right" version of JsPackageManager instance so there is no need to worry anywhere about that.
2020-06-08 20:08:15 +02:00
Gaëtan Maisse
a23e4a0846
refactor: move latestVersion to JsPackageManager and split specific behavior in NPM, Yarn 1 and Yarn 2 classes.
2020-06-08 20:08:15 +02:00
Gaëtan Maisse
126e7e2ea8
refactor: move getVersion to JsPackageManager
2020-06-08 17:25:45 +02:00
Gaëtan Maisse
2760021aa1
refactor: move getVersions to JsPackageManager
2020-06-08 17:25:45 +02:00
Gaëtan Maisse
b6497c2fec
refactor: move getVersionedPackages to JsPackageManager
2020-06-08 17:25:44 +02:00
Gaëtan Maisse
c714aca145
refactor: move installDependencies to JsPackageManager
...
Also rename it to `addDependencies` (a.k.a. `yarn add`) to avoid confusion with `installDepsFromPackageJson` (a.k.a. `yarn install`).
2020-06-08 17:25:44 +02:00
Gaëtan Maisse
56de607807
refactor: move retrievePackageJson to JsPackageManager
2020-06-08 17:25:44 +02:00
Gaëtan Maisse
10e4101b20
refactor: introduce JsPackageManager in all generators
2020-06-08 17:25:44 +02:00
Gaëtan Maisse
a858990fa6
refactor: move installDepsFromPackageJson function to JsPackageManager class and subclasses
2020-06-08 17:25:43 +02:00
Gaëtan Maisse
aa02e872dc
refactor: add tmp extract check to avoid issue in unit tests
...
As `hasYarn` function is called when `npm_init.ts` is parsed and loaded there are some issue with mock in unit tests.
2020-06-08 17:25:43 +02:00
Gaëtan Maisse
100ffac29c
refactor: use getRunStorybookCommand from package manager
...
It avoids to use a ternary expression to define the displayed string and encapsulate specific package managers behaviors in their own classes.
2020-06-08 17:25:43 +02:00
Gaëtan Maisse
0334c801fe
refactor: create a JsPackageManagerFactory
...
It returns an NPMProxy, YarnProxy or Yarn2Proxy according to user project setup:
Are `yarn` or `npm` command available? Is there any `yarn.lock` file?
2020-06-08 17:25:43 +02:00
Gaëtan Maisse
ed79e5bb42
refactor: introduce a JsPackageManager abstract class and specialized subclasses for NPM, Yarn and Yarn 2.
...
The goal of this will be to use the Factory Pattern to encapsulate everything specific to a package manager in a single class.
Then a factory will return an instance of NPM, Yarn or Yarn 2 proxy class according to the package manager used/prefered in end project.
All CLI code will be package manager agnostic and will just call functions of JsPackageManager interface.
2020-06-08 17:25:42 +02:00
Clément DUNGLER
41f557c348
Update main.js
2020-06-06 10:27:20 +02:00
Clément DUNGLER
c7d1f53a9e
Update main.js
2020-06-06 10:26:24 +02:00
tooppaaa
46c298ca54
fix e2e
2020-06-05 23:10:19 +02:00
Norbert de Langen
7b8897b36c
Merge branch 'next' into feature/e2eZeroConfig
...
# Conflicts:
# scripts/run-e2e.ts
# yarn.lock
2020-06-04 17:46:37 +02:00
Norbert de Langen
60b576ea51
Do not pass event to action, parsing it takes a long time, and we don't need to ensure that works
2020-06-04 14:59:10 +02:00
Gaëtan Maisse
7225ebb710
fix(cli): do not use --ignore-workspace-root-check with Yarn 2
...
This option is not handled by Yarn 2.
2020-06-03 21:13:48 +02:00
Gaëtan Maisse
d7687ade18
refactor: replace semver by @storybook/semver
...
`@storybook/semver` is a browser friendly fork of `semver`.
We use it to avoid issue with IE11 as classic "compiled" `semver` is now compatible with it.
If we just recompile `semver` from `node_modules` it ends with a package that `require('core-js')` but `core-js` is not listed in the dependency. And so Yarn 2 throw an error.
So to avoid that we need to use a "proper" dependency which is `semver` recompile and with all needed dependencies in its package.json.
2020-06-03 20:07:07 +02:00
Norbert de Langen
dfc9ee65e6
Merge pull request #10998 from storybookjs/mrmckeb/issue10943
...
Add warning for TypeScript set up issues and fix Babel config
2020-06-02 13:25:45 +02:00
Brody McKee
7ad9fcf533
feat: add warning for TypeScript setup issues
2020-06-02 11:16:24 +03:00
Gaëtan Maisse
10b34eea56
fix(cli): fix init command when run in a Yarn workspace env
...
Add `--ignore-workspace-root-check` to avoid Yarn error when adding dependencies to the workspace root.
2020-05-29 20:44:09 +02:00
Norbert de Langen
a4fa665ec2
Merge branch 'next' into fix/valid-globs
2020-05-27 10:39:31 +02:00
Norbert de Langen
540d0a2119
Merge branch 'next' into fix/valid-globs
...
# Conflicts:
# MIGRATION.md
2020-05-26 12:34:40 +02:00
tooppaaa
e5886f9584
Merge remote-tracking branch 'origin/next' into tech/e2eStab
2020-05-25 18:09:19 +02:00
Norbert de Langen
7b4e942c6d
Merge pull request #10909 from graup/graup/vue-preset
...
Remove babel-preset-vue
2020-05-25 13:19:33 +02:00
tooppaaa
12eff035d0
Merge remote-tracking branch 'origin/next' into tech/e2eStab
2020-05-25 13:08:52 +02:00
Paul Grau
286051a852
Remove leftover references to babel-preset-vue
2020-05-25 16:57:35 +09:00
Paul Grau
cfb55f2683
Remove jsx stories from vue generators
2020-05-25 16:28:29 +09:00
Michael Shilman
39bd026385
CSF: Upgrade TSX stories to hoisted story annotations
2020-05-25 13:39:27 +08:00
Michael Shilman
12e066bf6f
CSF: Upgrade JS stories to hoisted annotations
2020-05-25 13:32:05 +08:00
tooppaaa
746892fb88
Core: Stabilize E2E tests
2020-05-23 14:31:51 +02:00
Norbert de Langen
7a0fe8fe04
CHANGE all the main.js so their globs are valid
2020-05-22 16:07:48 +02:00
tooppaaa
ab78b076ed
Add e2e for zero config
2020-05-19 23:29:56 +02:00
Norbert de Langen
30c42223fe
Merge branch 'next' into tech/ci-example-overhaul-clean
...
# Conflicts:
# lib/cli/src/helpers.ts
# yarn.lock
2020-05-18 20:14:04 +02:00
tooppaaa
465b706bbf
less changes
2020-05-18 16:27:08 +02:00
Norbert de Langen
448bdddd29
Merge branch 'next' into tech/ci-example-overhaul-clean
...
# Conflicts:
# examples/angular-cli/jest.config.js
# lib/cli/src/generators/HTML/index.js
# lib/cli/src/generators/HTML/template-csf/stories/0-Welcome.stories.js
# yarn.lock
2020-05-18 14:21:17 +02:00
Gaëtan Maisse
5860974137
refactor(cli): improve typing of window
...
In order to be able to extend types in global scope with an `import` at the top of the file we have to create a new dedicated file (and can not use already existing typings.d.ts).
For details, see https://stackoverflow.com/questions/30960386/how-to-extend-the-window-typescript-interface/30961346#30961346
2020-05-17 17:08:00 +02:00
Gaëtan Maisse
ffa152204f
refactor(cli): use a unified type across all CLI generators
2020-05-17 16:49:01 +02:00
Yann Braga
cb149f6043
refactor(cli): use storyformat in aurelia generator
2020-05-17 14:53:46 +02:00
Yann Braga
bc237c7f5f
test(cli): fix types by casting storyformat
2020-05-17 14:20:13 +02:00
Yann Braga
7ea8f77705
refactor(cli): add storyformat to command options
2020-05-17 14:19:26 +02:00
Yann Braga
d1ffb883b0
refactor(cli): improve typings for supported language
2020-05-16 18:03:26 +02:00
