Norbert de Langen
2f84ecc71a
Merge branch 'next' into release/7.2
2023-07-10 10:11:11 +02:00
github-actions[bot]
a7275bce52
Merge branch 'next-release' into next
2023-07-10 08:08:18 +00:00
Norbert de Langen
49475a07d2
add manager Ui coverage
2023-07-10 09:27:44 +02:00
Norbert de Langen
0c6df8f7c4
make e2e tests less inconsistent
2023-07-10 09:27:24 +02:00
github-actions[bot]
47ab8dc8ad
Bump version from 7.1.0-beta.1 to 7.1.0-beta.2
2023-07-10 02:37:36 +00:00
Norbert de Langen
44da7e8405
Merge branch 'next' into release/7.2
2023-07-09 22:32:25 +02:00
Valentin Palkovic
a4d93b969b
Merge branch 'next' into patch-1
2023-07-07 16:18:54 +02:00
Valentin Palkovic
7c5fe03c94
Add semicolon
2023-07-07 16:18:23 +02:00
Norbert de Langen
8549fee839
Merge branch 'next' into release/7.2
2023-07-07 15:36:49 +02:00
Norbert de Langen
2c9b425eef
Merge pull request #23291 from storybookjs/norbert/improve-interaction-addon
...
InteractionsAddon: Improve code quality by using title as `FC` & sharing state via `useAddonState`
2023-07-07 15:35:50 +02:00
Norbert de Langen
f524baa37b
fixes for e2e tests
2023-07-07 15:14:12 +02:00
Norbert de Langen
b3bbb2bee3
Merge branch 'next' into release/7.2
2023-07-07 14:24:27 +02:00
Valentin Palkovic
3a476efe2c
Downgrade yarnpkg packages and support virtual files properly
2023-07-07 14:19:04 +02:00
Norbert de Langen
643678969c
Hopefully stabilize interactions e2e test
...
So… I discovered after a bunch of :computer-rage: ..
That the e2e test for interactions sometimes toggles the toolbar off.
When this happens it can’t click on the button to remount the story.
The toolbar disappears when playwright clicks on the addon tab, which appear like it refreshes storybook somehow, and then the toolbar disappears.
I cannot get playwright to do this locally, but I can see that something seems to be pressing t? Which toggles the toolbar.
What causes the refresh? what causes the toolbar to be toggle off? who knows?
I was trying to detect the presence of the toolbar to toggle back on, if needed,, and this is when things go weird.
Playwright tried to click the button, and can’t.. because it’s not visible.
So obviously I add a if statement, that if the button isn’t visible, it should do a procedure to ensure it will be, then try again.
Playwright tells me the button IS visible, but then when it tries to click says it isn’t. In addition using page.keyboard.press('t') doesn’t work to toggle the toolbar, very strange.
I even tried isWithinViewport()this suggests it’s in the viewport as well.
2023-07-07 14:07:08 +02:00
Michael Shilman
8d873b6e64
Build: Fix TOC stories for cra/default-js
2023-07-07 17:37:10 +08:00
Norbert de Langen
ca0d813818
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-more-addons
2023-07-06 23:05:51 +02:00
Norbert de Langen
e6aa8c9a43
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-interaction-addon
2023-07-06 23:05:44 +02:00
Norbert de Langen
3f2bc4380b
cleanup
2023-07-06 22:58:19 +02:00
Norbert de Langen
2964e4b296
fix
2023-07-06 22:00:13 +02:00
Norbert de Langen
f45772093f
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-more-addons
2023-07-06 21:30:22 +02:00
Norbert de Langen
4731d9601d
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-interaction-addon
2023-07-06 21:30:18 +02:00
Norbert de Langen
9facdc386c
Merge branch 'release/7.2' into norbert/ui-tabs-types-improvements
2023-07-06 21:29:40 +02:00
Norbert de Langen
25b35efb4c
Merge branch 'next' into release/7.2
2023-07-06 21:29:18 +02:00
Norbert de Langen
b7cee9329f
fix
2023-07-06 21:28:51 +02:00
github-actions[bot]
2731eb895d
Bump version from 7.1.0-beta.0 to 7.1.0-beta.1
2023-07-06 18:05:19 +00:00
Michael Shilman
184ba5b19d
Merge branch 'next' into revert-23333-revert-23142-shilman/toc-proof-of-concept
2023-07-07 01:40:23 +08:00
Norbert de Langen
9d0940d7b8
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-more-addons
2023-07-06 17:41:01 +02:00
Norbert de Langen
14184dec88
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-interaction-addon
2023-07-06 17:40:52 +02:00
Norbert de Langen
f32ead4746
cleanup
2023-07-06 17:39:40 +02:00
Norbert de Langen
8d82df3a7f
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-more-addons
2023-07-06 17:35:40 +02:00
Norbert de Langen
47c1356a57
Merge branch 'norbert/ui-tabs-types-improvements' into norbert/improve-interaction-addon
2023-07-06 17:35:05 +02:00
Norbert de Langen
b5072b2d77
Merge branch 'release/7.2' into norbert/improve-interaction-addon
2023-07-06 17:34:50 +02:00
Norbert de Langen
967e09dcbe
Merge branch 'release/7.2' into norbert/ui-tabs-types-improvements
2023-07-06 17:33:41 +02:00
Norbert de Langen
899380e4a0
Merge branch 'next' into release/7.2
2023-07-06 17:33:11 +02:00
Norbert de Langen
909a8512b5
simplify code
2023-07-06 17:32:30 +02:00
Norbert de Langen
e5189a1ab5
Merge branch 'norbert/ui-tabs-types-improvements' of github.com:storybookjs/storybook into norbert/ui-tabs-types-improvements
2023-07-06 17:24:34 +02:00
Norbert de Langen
c429c1f46b
make it prettier
2023-07-06 17:24:11 +02:00
Norbert de Langen
54eae22cf8
cleanup
2023-07-06 17:08:39 +02:00
jonniebigodes
21d5e5f1c3
Merge branch 'next' into patch-1
2023-07-06 15:47:07 +01:00
Michael Shilman
3756a92637
Revert "Revert "Addon-docs: Add opt-in table of contents""
2023-07-06 17:58:20 +08:00
Michael Shilman
deeac77377
Revert "Addon-docs: Add opt-in table of contents"
2023-07-06 17:54:03 +08:00
Michael Shilman
d8c8eb8fea
Merge branch 'next' into shilman/toc-proof-of-concept
2023-07-06 17:32:20 +08:00
Michael Shilman
995732e0a7
Update code/ui/blocks/src/components/TableOfContents.tsx
...
Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>
2023-07-06 17:31:38 +08:00
Valentin Palkovic
e5c4146f58
Merge remote-tracking branch 'upstream/next' into patch-1
2023-07-06 09:44:00 +02:00
Valentin Palkovic
6f346c25aa
Pin version of @yarnpkg packages to support Node 16
2023-07-06 09:11:15 +02:00
Michael Shilman
76ca248055
Cleanup
2023-07-06 00:27:53 +08:00
Michael Shilman
90c9929d32
Addon-docs: Fix TOC context bug
2023-07-06 00:23:38 +08:00
Michael Shilman
e09f436a8a
Addon-docs: Add TOC stories
2023-07-06 00:14:55 +08:00
Michael Shilman
43a5531da3
Remove spurious console.log
2023-07-06 00:13:04 +08:00
Michael Shilman
fe01f47500
Addon-docs: Fix bug where TOC is always showing
2023-07-06 00:12:39 +08:00
