GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 05:01:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated instruction message in setup.

Browse Source 
Added few comments in template.
Only notifies about not found app name if you use React Native Vanilla.
This commit is contained in:
Gytis Vinclovas 2018-10-10 09:55:33 +03:00
parent 5b78c5cd46
commit fde314b31e
3 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/cli/generators/REACT_NATIVE/index.js
View File

@ -29,16 +29,20 @@ export default async npmOptions => {
// set correct project name on entry files if possible
const dirname = shell.ls('-d', 'ios/*.xcodeproj').stdout;
const projectName =
dirname && dirname.slice('ios/'.length, dirname.length - '.xcodeproj'.length - 1);
if (projectName) {
shell.sed('-i', '%APP_NAME%', projectName, 'storybook/storybook.js');
} else {
paddedLog(
chalk.red(
'ERR: Could not determine project name, to fix: https://github.com/storybooks/storybook/issues/1277'
)
);
// Only notify about app name if running in React Native vanilla (Expo projects do not have ios directory)
if (dirname) {
const projectName =
dirname && dirname.slice('ios/'.length, dirname.length - '.xcodeproj'.length - 1);
if (projectName) {
shell.sed('-i', '%APP_NAME%', projectName, 'storybook/storybook.js');
} else {
paddedLog(
chalk.red(
'ERR: Could not determine project name, to fix: https://github.com/storybooks/storybook/issues/1277'
)
);
}
}
const packageJson = getPackageJson();

5
lib/cli/generators/REACT_NATIVE/template/storybook/index.js
View File

@ -8,7 +8,12 @@ configure(() => {
require('./stories');
}, module);
// Refer to https://github.com/storybooks/storybook/tree/master/app/react-native#start-command-parameters
// To find allowed options for getStorybookUI
const StorybookUIRoot = getStorybookUI({});
// If you are using React Native vanilla and after installation you don't see your app name here, write it manually.
// If you use Expo you can safely remove this line.
AppRegistry.registerComponent('%APP_NAME%', () => StorybookUIRoot);
export default StorybookUIRoot;

2
lib/cli/lib/initiate.js
View File

@ -103,7 +103,7 @@ export default function(options, pkg) {
logger.log(chalk.red('NOTE: installation is not 100% automated.'));
logger.log(`To quickly run storybook, replace contents of your app entry with:\n`);
codeLog(["export default from './storybook';"]);
logger.log('\nFor a more complete discussion of options, see:\n');
logger.log('\n For more in depth setup instructions, see:\n');
logger.log(chalk.cyan(REACT_NATIVE_DISCUSSION));
logger.log();
});