GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 21:51:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Extend new frameworks automigration to include Webpack4

Browse Source
This commit is contained in:
Michael Shilman 2022-08-15 18:42:12 +08:00
parent 9791f4e1f7
commit fcc4dca1e3
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
code/lib/cli/src/automigrate/fixes/new-frameworks.test.ts
View File

@ -60,7 +60,13 @@ describe('new-frameworks fix', () => {
framework: '@storybook/vue',
},
})
).resolves.toBeFalsy();
).resolves.toEqual(
expect.objectContaining({
frameworkPackage: '@storybook/vue-webpack5',
dependenciesToAdd: ['@storybook/vue-webpack5'],
dependenciesToRemove: ['@storybook/vue'],
})
);
});
it('in sb 7 with unsupported package', async () => {

19
code/lib/cli/src/automigrate/fixes/new-frameworks.ts
View File

@ -62,7 +62,7 @@ export const getBuilder = (builder: string | { name: string }) => {
return builder.includes('vite') ? 'vite' : 'webpack5';
}
return builder.name.includes('vite') ? 'vite' : 'webpack5';
return builder?.name.includes('vite') ? 'vite' : 'webpack5';
};
export const getFrameworkOptions = (framework: string, main: ConfigFile) => {
@ -113,7 +113,7 @@ export const newFrameworks: Fix<NewFrameworkRunOptions> = {
const frameworkPackage = main.getFieldValue(['framework']) as keyof typeof packagesMap;
const builder = main.getFieldValue(['core', 'builder']);
if (!frameworkPackage || !builder) {
if (!frameworkPackage) {
return null;
}
@ -138,6 +138,8 @@ export const newFrameworks: Fix<NewFrameworkRunOptions> = {
const dependenciesToRemove = [
'@storybook/builder-webpack5',
'@storybook/manager-webpack5',
'@storybook/builder-webpack4',
'@storybook/manager-webpack4',
].filter((dep) => allDeps[dep]);
const newFrameworkPackage = packagesMap[frameworkPackage][builderInfo.name];
@ -168,9 +170,20 @@ export const newFrameworks: Fix<NewFrameworkRunOptions> = {
We can remove the dependencies that are no longer needed and install the new framework that already includes the builder.
More info: ${chalk.yellow(
To learn more about the framework field, see: ${chalk.yellow(
'https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#framework-field-mandatory'
)}
${chalk.underline(chalk.bold(chalk.cyan('Webpack4 users')))}
Unless you're using Storybook's Vite builder, this automigration will install a Webpack5-based framework.
If you were using Storybook's Webpack4 builder (default in 6.x, discontinued in 7.0), this could be a breaking
change--especially if your project has a custom webpack configuration.
To learn more about migrating from Webpack4, see: ${chalk.yellow(
'https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack4-support-discontinued'
)}
`;
},