GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 08:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix memory leak in vue3 renderer"

Browse Source 
This reverts commit a9e4e17530b4374c05c8da8224f252694c28719d.
This commit is contained in:
Jeppe Reinhold 2022-11-03 20:04:02 +01:00
parent 5768746469
commit f8e6ca179f
1 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
code/renderers/vue3/src/render.ts
View File

@ -20,31 +20,20 @@ export const setup = (fn: (app: any) => void) => {
setupFunction = fn; setupFunction = fn;
}; };
const componentsByDomElementId = new Map<string, ReturnType<typeof createApp>>(); const map = new Map<Element, ReturnType<typeof createApp>>();
export function renderToDOM( export function renderToDOM(
{ { title, name, storyFn, showMain, showError, showException }: Store_RenderContext<VueFramework>,
title,
name,
storyFn,
showMain,
showError,
showException,
storyContext,
}: Store_RenderContext<VueFramework>,
domElement: Element domElement: Element
) { ) {
// in docs mode we're rendering multiple stories to the DOM, so we need to key by the story id
const domElementKey = storyContext.viewMode === 'docs' ? storyContext.id : 'storybook-root';
// TODO: explain cyclical nature of these app => story => mount // TODO: explain cyclical nature of these app => story => mount
let element: StoryFnVueReturnType; let element: StoryFnVueReturnType;
const storybookApp = createApp({ const storybookApp = createApp({
unmounted() { unmounted() {
componentsByDomElementId.delete(domElementKey); map.delete(domElement);
}, },
render() { render() {
componentsByDomElementId.set(domElementKey, storybookApp); map.set(domElement, storybookApp);
setupFunction(storybookApp); setupFunction(storybookApp);
return h(element); return h(element);
}, },
@ -65,7 +54,7 @@ export function renderToDOM(
showMain(); showMain();
componentsByDomElementId.get(domElementKey)?.unmount(); map.get(domElement)?.unmount();
storybookApp.mount(domElement); storybookApp.mount(domElement);
} }