GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 15:31:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Props: Fix subcomponents & update story to test it

Browse Source
This commit is contained in:
Michael Shilman 2020-05-01 18:46:03 +08:00
parent 11ad35dd26
commit f789985eba
2 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
addons/docs/src/blocks/Props.tsx
View File

@ -160,15 +160,17 @@ export const StoryTable: FC<StoryProps & { components: Record<string, Component>
// eslint-disable-next-line prefer-const
let [args, updateArgs] = useArgs(storyId, storyStore);
if (!storyArgTypes || !Object.values(storyArgTypes).find((v) => !!v?.control)) {
updateArgs = null;
}
let tabs = { Story: { rows: storyArgTypes, args, updateArgs } } as Record<
string,
ArgsTableProps
>;
if (showComponents) {
if (!storyArgTypes || !Object.values(storyArgTypes).find((v) => !!v?.control)) {
updateArgs = null;
tabs = {};
}
// Use the dynamically generated component tabs if there are no controls
if (showComponents || !updateArgs) {
tabs = addComponentTabs(tabs, components, context, include, exclude);
}

14
examples/official-storybook/stories/addon-docs/subcomponents.stories.js
View File

@ -7,21 +7,9 @@ export default {
component: ButtonGroup,
parameters: { viewMode: 'docs' },
subcomponents: { DocgenButton },
argTypes: {
background: {
control: { type: 'color' },
},
},
};
export const Args = (args) => (
<ButtonGroup {...args}>
<DocgenButton label="foo" />
<DocgenButton label="bar" />
</ButtonGroup>
);
export const NoArgs = () => (
export const Basic = () => (
<ButtonGroup background="#eee">
<DocgenButton label="foo" />
<DocgenButton label="bar" />