GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 16:11:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

skip sb-binary automigration in nx projects

Browse Source
This commit is contained in:
Yann Braga 2023-02-16 18:16:34 +01:00
parent de9b793ff3
commit f5c29e7bfb
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
code/lib/cli/src/automigrate/fixes/sb-binary.test.ts
View File

@ -23,6 +23,17 @@ describe('storybook-binary fix', () => {
});
describe('sb >= 7.0', () => {
it('should no-op in NX projects', async () => {
const packageJson = {
dependencies: { '@storybook/react': '^7.0.0', '@nrwl/storybook': '^15.7.1' },
};
await expect(
checkStorybookBinary({
packageJson,
})
).resolves.toBeFalsy();
});
it('should add storybook dependency if not present', async () => {
const packageJson = {
dependencies: {

3
code/lib/cli/src/automigrate/fixes/sb-binary.ts
View File

@ -40,7 +40,8 @@ export const sbBinary: Fix<SbBinaryRunOptions> = {
`);
}
if (semver.lt(storybookCoerced, '7.0.0')) {
// Nx provides their own binary, so we don't need to do anything
if (allDeps['@nrwl/storybook'] || semver.lt(storybookCoerced, '7.0.0')) {
return null;
}