GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 22:21:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition on about page

Browse Source
This commit is contained in:
Michael Shilman 2019-06-17 10:57:29 +08:00
parent 142321d69b
commit f5a1ec01db
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/ui/src/settings/about.js
View File

@ -1,4 +1,5 @@
import React, { Fragment } from 'react';
import semver from 'semver';
import PropTypes from 'prop-types';
import { styled } from '@storybook/theming';
import { GlobalHotKeys } from 'react-hotkeys';
@ -93,7 +94,7 @@ const Container = styled.div({
});
const AboutScreen = ({ latest, current, onClose }) => {
const canUpdate = latest && latest.version !== current.version;
const canUpdate = latest && semver.gt(latest.version, current.version);
let updateMessage;
if (latest) {

3
lib/ui/src/settings/about.stories.js
View File

@ -24,6 +24,9 @@ storiesOf('UI|Settings/AboutScreen', module)
.add('up to date', () => (
<AboutScreen latest={{ version: '5.0.0', info }} current={{ version: '5.0.0' }} {...actions} />
))
.add('old version race condition', () => (
<AboutScreen latest={{ version: '5.0.0', info }} current={{ version: '5.0.3' }} {...actions} />
))
.add('new version required', () => (
<AboutScreen latest={{ version: '5.0.3', info }} current={{ version: '5.0.0' }} {...actions} />
))