GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 16:11:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Core: Update story_store to keep _data and _legacydata in sync

Browse Source
This commit is contained in:
Michael Shilman 2019-07-05 15:51:56 +08:00
parent 4db4dc4978
commit e59fab57e2
2 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/client-api/src/story_store.js
View File

@ -114,7 +114,13 @@ export default class StoryStore extends EventEmitter {
remove = id => {
const { _data } = this;
const { kind, name } = _data[id];
delete _data[id];
const kindData = this._legacydata[toKey(kind)];
if (kindData) {
delete kindData.stories[toKey(name)];
}
};
addStory(
@ -271,6 +277,13 @@ export default class StoryStore extends EventEmitter {
removeStoryKind(kind) {
if (this.hasStoryKind(kind)) {
this._legacydata[toKey(kind)].stories = {};
this._data = Object.entries(this._data).reduce((acc, [id, story]) => {
if (story.kind !== kind) {
Object.assign(acc, { [id]: story });
}
return acc;
}, {});
}
}

35
lib/client-api/src/story_store.test.js
View File

@ -95,6 +95,41 @@ describe('preview.story_store', () => {
const store = new StoryStore({ channel });
store.removeStoryKind('kind');
});
it('should remove the kind in both modern and legacy APIs', () => {
const store = new StoryStore({ channel });
store.addStory(...make('kind-1', 'story-1.1', () => 0));
store.addStory(...make('kind-1', 'story-1.2', () => 0));
store.addStory(...make('kind-2', 'story-2.1', () => 0));
store.addStory(...make('kind-2', 'story-2.2', () => 0));
store.removeStoryKind('kind-1');
// _legacydata
expect(store.hasStory('kind-1', 'story-1.1')).toBeFalsy();
expect(store.hasStory('kind-2', 'story-2.1')).toBeTruthy();
// _data
expect(store.fromId(toId('kind-1', 'story-1.1'))).toBeFalsy();
expect(store.fromId(toId('kind-2', 'story-2.1'))).toBeTruthy();
});
});
describe('remove', () => {
it('should remove the kind in both modern and legacy APIs', () => {
const store = new StoryStore({ channel });
store.addStory(...make('kind-1', 'story-1.1', () => 0));
store.addStory(...make('kind-1', 'story-1.2', () => 0));
store.remove(toId('kind-1', 'story-1.1'));
// _legacydata
expect(store.hasStory('kind-1', 'story-1.1')).toBeFalsy();
expect(store.hasStory('kind-1', 'story-1.2')).toBeTruthy();
// _data
expect(store.fromId(toId('kind-1', 'story-1.1'))).toBeFalsy();
expect(store.fromId(toId('kind-1', 'story-1.2'))).toBeTruthy();
});
});
describe('getStoryAndParameters', () => {