GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 07:21:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2138 from storybooks/dd/fix-info-opt-desc

Browse Source 
Fix info upgrade codemod failing when optional description string is not supplied
This commit is contained in:
Daniel Duan 2017-10-27 21:46:40 -04:00 committed by GitHub
commit de474b68be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/codemod/src/transforms/__testfixtures__/update-addon-info/update-addon-info.input.js
View File

@ -188,3 +188,11 @@ storiesOf('Button').addWithInfo(
} }
} }
) )
storiesOf('shared/ProgressBar', module)
.addDecorator(withKnobs)
.addWithInfo('default style', () => (
<ProgressBar progress={number('progress', 25)}
delay={number('delay', 500)}
/>
));

8
lib/codemod/src/transforms/__testfixtures__/update-addon-info/update-addon-info.output.js
View File

@ -184,3 +184,11 @@ storiesOf('Button').add('with custom styles', withInfo({
return stylesheet return stylesheet
} }
})(() => <Button label="The Button" onClick={action('onClick')} />)) })(() => <Button label="The Button" onClick={action('onClick')} />))
storiesOf('shared/ProgressBar', module)
.addDecorator(withKnobs)
.add('default style', withInfo('default style')(() => (
<ProgressBar progress={number('progress', 25)}
delay={number('delay', 500)}
/>
)));

11
lib/codemod/src/transforms/update-addon-info.js
View File

@ -36,6 +36,10 @@ export default function transformer(file, api) {
*/ */
const getOptions = args => { const getOptions = args => {
if (args[3] === undefined) { if (args[3] === undefined) {
if (args[2] === undefined) {
// when the optional description string is not supplied for addWithInfo, just use story name
return [args[0]];
}
return [args[1]]; return [args[1]];
} }
return [ return [
@ -56,10 +60,15 @@ export default function transformer(file, api) {
const node = addWithInfoExpression.node; const node = addWithInfoExpression.node;
const args = node.arguments; const args = node.arguments;
// if optional description string is not supplied, the story component becomes second arg
const storyComponent = args[2] ? args[2] : args[1];
node.callee.property.name = 'add'; node.callee.property.name = 'add';
node.arguments = [ node.arguments = [
args[0], args[0],
j.callExpression(j.callExpression(j.identifier('withInfo'), getOptions(args)), [args[2]]), j.callExpression(j.callExpression(j.identifier('withInfo'), getOptions(args)), [
storyComponent,
]),
]; ];
return node; return node;