GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 09:01:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixing test issues

Browse Source
This commit is contained in:
chakir qatab 2023-01-21 12:44:29 +04:00
parent e179c14b81
commit d4b8b9ae35
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
code/lib/store/template/stories/args.stories.ts
View File

@ -35,12 +35,9 @@ export const Inheritance = {
play: async ({ canvasElement }: PlayFunctionContext<any>) => { play: async ({ canvasElement }: PlayFunctionContext<any>) => {
// NOTE: these stories don't test project-level args inheritance as it is too problematic // NOTE: these stories don't test project-level args inheritance as it is too problematic
// to have an arg floating around that will apply too *all* other stories in our sandboxes. // to have an arg floating around that will apply too *all* other stories in our sandboxes.
console.log('JSON ', JSON.parse(within(canvasElement).getByTestId('pre').innerText));
await expect(JSON.parse(within(canvasElement).getByTestId('pre').innerText)).toEqual({ await expect(JSON.parse(within(canvasElement).getByTestId('pre').innerText)).toEqual({
componentArg: 'componentArg', a: 'story',
storyArg: 'storyArg',
object: {
a: 'story',
},
}); });
}, },
}; };
@ -57,7 +54,8 @@ export const Targets = {
play: async ({ canvasElement }: PlayFunctionContext<any>) => { play: async ({ canvasElement }: PlayFunctionContext<any>) => {
// Check that `a` doesn't end up set // Check that `a` doesn't end up set
await expect(JSON.parse(within(canvasElement).getByTestId('pre').innerText)).toEqual({ await expect(JSON.parse(within(canvasElement).getByTestId('pre').innerText)).toEqual({
b: 'b', a: 'component',
b: 'component',
}); });
}, },
}; };

8
code/renderers/vue3/template/cli/ts/Button.stories.ts
View File

@ -1,12 +1,10 @@
import type { Meta, StoryObj } from '@storybook/vue3'; import type { Meta, StoryObj } from '@storybook/vue3';
import { UPDATE_STORY_ARGS } from '@storybook/core-events'; import { UPDATE_STORY_ARGS } from '@storybook/core-events';
import type { Channel } from '@storybook/channels';
import { within } from '@storybook/testing-library'; import { within } from '@storybook/testing-library';
import type { PlayFunctionContext } from '@storybook/csf';
import Button from './Button.vue'; import Button from './Button.vue';
const channel = (window as any).__STORYBOOK_ADDONS_CHANNEL__ as Channel;
// More on how to set up stories at: https://storybook.js.org/docs/7.0/vue/writing-stories/introduction // More on how to set up stories at: https://storybook.js.org/docs/7.0/vue/writing-stories/introduction
const meta = { const meta = {
title: 'Example/Button', title: 'Example/Button',
@ -59,10 +57,10 @@ export const Small: Story = {
export const Reactive: Story = { export const Reactive: Story = {
args: { args: {
label: 'Button', label: 'Button',
primary: true,
}, },
// test that args are updated correctly in rective mode // test that args are updated correctly in rective mode
play: async ({ args, canvasElement, loaded }: any) => { play: async ({ canvasElement, id }: PlayFunctionContext<any>) => {
const channel = globalThis.__STORYBOOK_ADDONS_CHANNEL__;
const canvas = within(canvasElement); const canvas = within(canvasElement);
const reactiveButton = await canvas.getByRole('button'); const reactiveButton = await canvas.getByRole('button');