GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 16:01:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5983 from Armanio/fix/stories

Browse Source 
fix(stories): `selectStory` correct behavior on call with one parameter
This commit is contained in:
Michael Shilman 2019-03-09 22:15:47 +08:00 committed by GitHub
commit d3ef9d6c78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/ui/src/core/stories.js
View File

@ -195,9 +195,12 @@ const initStoriesApi = ({
};
const selectStory = (kindOrId, story) => {
const { viewMode = 'story', storyId } = store.getState();
const { viewMode = 'story', storyId, storiesHash } = store.getState();
if (!story) {
navigate(`/${viewMode}/${kindOrId}`);
const s = storiesHash[sanitize(kindOrId)];
// eslint-disable-next-line no-nested-ternary
const id = s ? (s.children ? s.children[0] : s.id) : kindOrId;
navigate(`/${viewMode}/${id}`);
} else if (!kindOrId) {
// This is a slugified version of the kind, but that's OK, our toId function is idempotent
const kind = storyId.split('--', 2)[0];

15
lib/ui/src/core/stories.test.js
View File

@ -400,5 +400,20 @@ describe('stories API', () => {
selectStory(null, '2');
expect(navigate).toHaveBeenCalledWith('/story/a--2');
});
it('allows navigating to first story in kind on call by kind', () => {
const navigate = jest.fn();
const store = createMockStore();
const {
api: { selectStory, setStories },
state,
} = initStories({ store, navigate });
store.setState(state);
setStories(storiesHash);
selectStory('a');
expect(navigate).toHaveBeenCalledWith('/story/a--1');
});
});
});