GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-08 11:11:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1664 from danielsneijers/1588-fix-leftpanel-init-proptype-warning

Browse Source 
Don’t render leftpanel stories tree if stories are empty
This commit is contained in:
Norbert de Langen 2017-08-16 16:28:15 +02:00 committed by GitHub
commit d2be2c893f
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ui/src/modules/ui/components/left_panel/index.js
View File

@ -25,6 +25,10 @@ const storyProps = [
'sidebarAnimations',
];
function hierarchyContainsStories(storiesHierarchy) {
return storiesHierarchy && storiesHierarchy.map.size
}
// eslint-disable-next-line react/prefer-stateless-function
class LeftPanel extends Component {
render() {
@ -46,7 +50,9 @@ class LeftPanel extends Component {
onChange={text => onStoryFilter(text)}
/>
<div style={scrollStyle}>
{storiesHierarchy ? <Stories {...pick(this.props, storyProps)} /> : null}
{hierarchyContainsStories(storiesHierarchy)
? <Stories {...pick(this.props, storyProps)} />
: null}
</div>
</div>
);

7
lib/ui/src/modules/ui/components/left_panel/index.test.js
View File

@ -44,6 +44,13 @@ describe('manager.ui.components.left_panel.index', () => {
});
});
test('should not render stories if storiesHierarchy exists but is empty', () => {
const storiesHierarchy = createHierarchy([]);
const wrap = shallow(<LeftPanel storiesHierarchy={storiesHierarchy} />);
expect(wrap.find(Stories).exists()).toBe(false);
});
describe('onStoryFilter prop', () => {
test('should set filter as an empty text on TextFilter.onClear', () => {
const onStoryFilter = jest.fn();