GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 15:31:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #17840 from storybookjs/tech/fix-e2e-tests

Browse Source 
Build: Swap order of e2e tests around
This commit is contained in:
Michael Shilman 2022-03-31 22:14:35 +08:00 committed by GitHub
commit d20eb1b5a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
addons/docs/package.json
View File

@ -77,6 +77,7 @@
"fast-deep-equal": "^3.1.3",
"global": "^4.4.0",
"lodash": "^4.17.21",
"regenerator-runtime": "^0.13.7",
"remark-external-links": "^8.0.0",
"remark-slug": "^6.0.0",
"ts-dedent": "^2.0.0",

14
cypress/generated/basic.spec.ts
View File

@ -58,13 +58,6 @@ describe('Basic CLI', () => {
});
describe('Page story', () => {
it('should load and display logged in', () => {
cy.navigateToStory('example-page', 'logged-in');
cy.getStoryElement().find('header').should('contain.text', 'Acme');
cy.getStoryElement().find('button').should('contain.text', 'Log out');
cy.getStoryElement().should('contain.text', 'Pages in Storybook');
});
it('should load and display logged out', () => {
cy.navigateToStory('example-page', 'logged-out');
cy.getStoryElement().should('contain.text', 'Acme');
@ -72,5 +65,12 @@ describe('Basic CLI', () => {
cy.getStoryElement().find('button').last().should('contain.text', 'Sign up');
cy.getStoryElement().should('contain.text', 'Pages in Storybook');
});
it('should load and display logged in', () => {
cy.navigateToStory('example-page', 'logged-in');
cy.getStoryElement().find('header').should('contain.text', 'Acme');
cy.getStoryElement().find('button').should('contain.text', 'Log out');
cy.getStoryElement().should('contain.text', 'Pages in Storybook');
});
});
});

10
cypress/support/commands.js
View File

@ -97,12 +97,18 @@ Cypress.Commands.add('navigateToStory', (kind, name) => {
const storyLinkId = `#${kindId}--${storyId}`;
cy.log(`navigateToStory ${kind} ${name}`);
// docs-only stories
if (name !== 'page') {
// Section might be collapsed
cy.get(`#${kindId}`).then(($item) => {
if ($item.attr('aria-expanded') === 'false') $item.click();
cy.get(`#${kindId}`).then(async ($item) => {
if ($item.attr('aria-expanded') === 'false') {
await $item.click();
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(300);
}
});
}
cy.get(storyLinkId).click({ force: true });
// FIXME: Find a way to not wait like this but check for an element in the UI

1
yarn.lock
View File

@ -6346,6 +6346,7 @@ __metadata:
fast-deep-equal: ^3.1.3
global: ^4.4.0
lodash: ^4.17.21
regenerator-runtime: ^0.13.7
remark-external-links: ^8.0.0
remark-slug: ^6.0.0
ts-dedent: ^2.0.0