GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 20:11:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

warn vite+next users about the nextjs package

Browse Source
This commit is contained in:
Yann Braga 2022-10-21 16:48:22 +02:00
parent 2b4e3a7bb9
commit d1adc1eb89
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
code/lib/cli/src/automigrate/fixes/nextjs-framework.test.ts
View File

@ -158,6 +158,26 @@ describe('nextjs-framework fix', () => {
);
});
it.todo('should just warn for @storybook/react-vite users');
it('should warn for @storybook/react-vite users', async () => {
const consoleSpy = jest.spyOn(console, 'info');
const packageJson = {
dependencies: {
'@storybook/react': '^7.0.0-alpha.0',
'@storybook/react-vite': '^7.0.0-alpha.0',
next: '^12.0.0',
'storybook-addon-next': '^1.0.0',
},
};
await expect(
checkNextjsFramework({
packageJson,
main: {
framework: { name: '@storybook/react-vite' },
},
})
).resolves.toBeFalsy();
expect(consoleSpy).toHaveBeenCalledWith(expect.stringContaining('Vite builder'));
});
});
});

17
code/lib/cli/src/automigrate/fixes/nextjs-framework.ts
View File

@ -85,6 +85,23 @@ export const nextjsFramework: Fix<NextjsFrameworkRunOptions> = {
const frameworkPackageName =
typeof frameworkPackage === 'string' ? frameworkPackage : frameworkPackage.name;
if (frameworkPackageName === '@storybook/react-vite') {
logger.info(dedent`
We've detected you are using Storybook in a Next.js project.
In Storybook 7, we introduced a new framework package for Next.js projects: @storybook/nextjs.
This package provides a better experience for Next.js users, however it is only compatible with the webpack 5 builder, so we can't automigrate for you, as you are using the Vite builder.
If you are interested in using this package, see: ${chalk.yellow(
'https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#nextjs-framework'
)}
`);
return null;
}
// we only migrate from react-webpack5 projects
if (frameworkPackageName !== '@storybook/react-webpack5') {
return null;