GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 22:51:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7319 from storybookjs/7169-fix-renaming-stories

Browse Source 
Addon-docs: Fix renaming stories on module / MDX format
This commit is contained in:
Michael Shilman 2019-07-06 07:31:34 +08:00 committed by GitHub
commit cd87934497
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/client-api/src/story_store.js
View File

@ -114,7 +114,16 @@ export default class StoryStore extends EventEmitter {
remove = id => {
const { _data } = this;
const story = _data[id];
delete _data[id];
if (story) {
const { kind, name } = story;
const kindData = this._legacydata[toKey(kind)];
if (kindData) {
delete kindData.stories[toKey(name)];
}
}
};
addStory(
@ -271,6 +280,13 @@ export default class StoryStore extends EventEmitter {
removeStoryKind(kind) {
if (this.hasStoryKind(kind)) {
this._legacydata[toKey(kind)].stories = {};
this._data = Object.entries(this._data).reduce((acc, [id, story]) => {
if (story.kind !== kind) {
Object.assign(acc, { [id]: story });
}
return acc;
}, {});
}
}

35
lib/client-api/src/story_store.test.js
View File

@ -95,6 +95,41 @@ describe('preview.story_store', () => {
const store = new StoryStore({ channel });
store.removeStoryKind('kind');
});
it('should remove the kind in both modern and legacy APIs', () => {
const store = new StoryStore({ channel });
store.addStory(...make('kind-1', 'story-1.1', () => 0));
store.addStory(...make('kind-1', 'story-1.2', () => 0));
store.addStory(...make('kind-2', 'story-2.1', () => 0));
store.addStory(...make('kind-2', 'story-2.2', () => 0));
store.removeStoryKind('kind-1');
// _legacydata
expect(store.hasStory('kind-1', 'story-1.1')).toBeFalsy();
expect(store.hasStory('kind-2', 'story-2.1')).toBeTruthy();
// _data
expect(store.fromId(toId('kind-1', 'story-1.1'))).toBeFalsy();
expect(store.fromId(toId('kind-2', 'story-2.1'))).toBeTruthy();
});
});
describe('remove', () => {
it('should remove the kind in both modern and legacy APIs', () => {
const store = new StoryStore({ channel });
store.addStory(...make('kind-1', 'story-1.1', () => 0));
store.addStory(...make('kind-1', 'story-1.2', () => 0));
store.remove(toId('kind-1', 'story-1.1'));
// _legacydata
expect(store.hasStory('kind-1', 'story-1.1')).toBeFalsy();
expect(store.hasStory('kind-1', 'story-1.2')).toBeTruthy();
// _data
expect(store.fromId(toId('kind-1', 'story-1.1'))).toBeFalsy();
expect(store.fromId(toId('kind-1', 'story-1.2'))).toBeTruthy();
});
});
describe('getStoryAndParameters', () => {