Promote no-extraneous-dependencies to error level and make it pass

.eslintrc.js

@@ -40,9 +40,12 @@ module.exports = {
       },
     ],
     'import/no-extraneous-dependencies': [
-      warn,
+      error,
       {
         devDependencies: [
+          'examples/**',
+          '**/example/**',
+          '*.js',
           '**/*.test.js',
           '**/scripts/*.js',
           '**/stories/*.js',

addons/comments/package.json

@@ -36,6 +36,8 @@
     "react-textarea-autosize": "^4.3.0"
   },
   "devDependencies": {
+    "@storybook/react": "^3.2.5",
+    "@storybook/addon-actions": "^3.2.0",
     "@kadira/storybook-database-cloud": "*",
     "@kadira/storybook-deployer": "*",
     "git-url-parse": "^6.2.2",

addons/comments/src/stories/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved */
-
 import React from 'react';
 import { storiesOf } from '@storybook/react';
 import { action } from '@storybook/addon-actions';

addons/notes/package.json

@@ -21,11 +21,11 @@
   "dependencies": {
     "@storybook/addons": "^3.2.0",
     "babel-runtime": "^6.23.0",
+    "prop-types": "^15.5.10",
     "util-deprecate": "^1.0.2"
   },
   "devDependencies": {
     "git-url-parse": "^6.2.2",
-    "prop-types": "^15.5.10",
     "react": "^15.6.1",
     "react-addons-test-utils": "^15.5.1",
     "react-dom": "^15.6.1"

addons/notes/src/register.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React from 'react';
 import PropTypes from 'prop-types';
 import addons from '@storybook/addons';

docs/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+  settings: {
+    'import/core-modules': ['config'],
+  },
+};

examples/crna-kitchen-sink/storybook/stories/Button/index.android.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { TouchableNativeFeedback } from 'react-native';
 

examples/crna-kitchen-sink/storybook/stories/Button/index.ios.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { TouchableHighlight } from 'react-native';
 

examples/crna-kitchen-sink/storybook/stories/CenterView/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { View } from 'react-native';
 import style from './style';

examples/crna-kitchen-sink/storybook/stories/Welcome/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { View, Text } from 'react-native';
 

examples/react-native-vanilla/storybook/stories/Button/index.android.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { TouchableNativeFeedback } from 'react-native';
 

examples/react-native-vanilla/storybook/stories/Button/index.ios.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { TouchableHighlight } from 'react-native';
 

examples/react-native-vanilla/storybook/stories/CenterView/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { View } from 'react-native';
 import style from './style';

examples/react-native-vanilla/storybook/stories/Welcome/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
-
 import React, { PropTypes } from 'react';
 import { View, Text } from 'react-native';
 

lib/cli/generators/.eslintrc.js

@@ -1,11 +1,14 @@
 const ignore = 0;
 
 module.exports = {
-  rules: {
-    'import/no-unresolved': ignore,
-    'import/no-extraneous-dependencies': ignore,
-    'import/extensions': ignore,
-    'global-require': ignore,
-    'no-console': ignore,
+  overrides: {
+    files: '*/template/**',
+    rules: {
+      'import/no-unresolved': ignore,
+      'import/no-extraneous-dependencies': ignore,
+      'import/extensions': ignore,
+      'global-require': ignore,
+      'no-console': ignore,
+    },
   },
 };

lib/cli/generators/METEOR/index.js

@@ -1,9 +1,10 @@
+import latestVersion from 'latest-version';
+
 const mergeDirs = require('merge-dirs').default;
 const helpers = require('../../lib/helpers');
 const path = require('path');
 const fs = require('fs');
 const JSON5 = require('json5');
-const latestVersion = require('latest-version');
 
 module.exports = Promise.all([
   latestVersion('@storybook/react'),

lib/cli/package.json

@@ -31,6 +31,7 @@
     "cross-spawn": "^5.0.1",
     "jscodeshift": "^0.3.30",
     "json5": "^0.5.1",
+    "latest-version": "^3.1.0",
     "merge-dirs": "^0.2.1",
     "opencollective": "^1.0.3",
     "shelljs": "^0.7.8",

package.json

@@ -62,6 +62,7 @@
     "jest-enzyme": "^3.6.1",
     "lerna": "2.0.0",
     "lint-staged": "^4.0.2",
+    "lodash": "^4.17.4",
     "nodemon": "^1.11.0",
     "npmlog": "^4.1.2",
     "prettier": "^1.5.3",