GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 22:11:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4649 from transitive-bullshit/bug/build-static-promise

Browse Source 
Fix a bug with buildStaticStandalone resolving too early
This commit is contained in:
Igor 2018-11-05 11:04:29 +02:00 committed by GitHub
commit c8bc4cc2ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
lib/core/src/server/build-static.js
View File

@ -41,26 +41,30 @@ export async function buildStaticStandalone(options) {
}
// compile all resources with webpack and write them to the disk.
logger.info('Building storybook ...');
const webpackCb = (err, stats) => {
if (err || stats.hasErrors()) {
logger.error('Failed to build the storybook');
// eslint-disable-next-line no-unused-expressions
err && logger.error(err.message);
// eslint-disable-next-line no-unused-expressions
stats && stats.hasErrors() && stats.toJson().errors.forEach(e => logger.error(e));
process.exitCode = 1;
return new Promise((resolve, reject) => {
const webpackCb = (err, stats) => {
if (err || stats.hasErrors()) {
logger.error('Failed to build the storybook');
// eslint-disable-next-line no-unused-expressions
err && logger.error(err.message);
// eslint-disable-next-line no-unused-expressions
stats && stats.hasErrors() && stats.toJson().errors.forEach(e => logger.error(e));
process.exitCode = 1;
return reject(err);
}
logger.info('Building storybook completed.');
return resolve(stats);
};
logger.info('Building storybook ...');
const compiler = webpack(config);
if (watch) {
compiler.watch({}, webpackCb);
} else {
compiler.run(webpackCb);
}
logger.info('Building storybook completed.');
};
const compiler = webpack(config);
if (watch) {
compiler.watch({}, webpackCb);
} else {
compiler.run(webpackCb);
}
});
}
export async function buildStatic({ packageJson, ...loadOptions }) {