GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-03-21 05:02:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(cli): supportedLanguages -> SUPPORTED_LANGUAGES

Browse Source
This commit is contained in:
Yann Braga 2020-04-26 11:56:42 +02:00
parent 519fc1af88
commit c7770f73cb
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cli/src/detect.js
View File

@ -4,7 +4,7 @@ import fs from 'fs';
import types, {
supportedTemplates,
supportedFrameworks,
supportedLanguages,
SUPPORTED_LANGUAGES,
} from './project_types';
import { getBowerJson, getPackageJson } from './helpers';
@ -92,7 +92,7 @@ export function isStorybookInstalled(dependencies, force) {
}
export function detectLanguage() {
let language = supportedLanguages.JAVASCRIPT;
let language = SUPPORTED_LANGUAGES.JAVASCRIPT;
const packageJson = getPackageJson();
const bowerJson = getBowerJson();
if (!packageJson && !bowerJson) {
@ -100,7 +100,7 @@ export function detectLanguage() {
}
if (hasDependency(packageJson || bowerJson, 'typescript')) {
language = supportedLanguages.TYPESCRIPT;
language = SUPPORTED_LANGUAGES.TYPESCRIPT;
}
return language;

6
lib/cli/src/detect.test.js
View File

@ -2,7 +2,7 @@ import fs from 'fs';
import { getBowerJson, getPackageJson } from './helpers';
import { isStorybookInstalled, detectFrameworkPreset, detect, detectLanguage } from './detect';
import projectTypes, { supportedFrameworks, supportedLanguages } from './project_types';
import projectTypes, { supportedFrameworks, SUPPORTED_LANGUAGES } from './project_types';
jest.mock('./helpers', () => ({
getBowerJson: jest.fn(),
@ -215,12 +215,12 @@ describe('Detect', () => {
typescript: '1.0.0',
},
}));
expect(detectLanguage()).toBe(supportedLanguages.TYPESCRIPT);
expect(detectLanguage()).toBe(SUPPORTED_LANGUAGES.TYPESCRIPT);
});
it(`should return language javascript by default`, () => {
getPackageJson.mockImplementation(() => true);
expect(detectLanguage()).toBe(supportedLanguages.JAVASCRIPT);
expect(detectLanguage()).toBe(SUPPORTED_LANGUAGES.JAVASCRIPT);
});
describe('isStorybookInstalled should return', () => {

4
lib/cli/src/initiate.js
View File

@ -6,7 +6,7 @@ import { hasYarn } from './has_yarn';
import types, {
installableProjectTypes,
STORY_FORMAT,
supportedLanguages,
SUPPORTED_LANGUAGES,
} from './project_types';
import {
commandLog,
@ -47,7 +47,7 @@ const installStorybook = (projectType, options) => {
};
const defaultStoryFormat =
detectLanguage() === supportedLanguages.TYPESCRIPT
detectLanguage() === SUPPORTED_LANGUAGES.TYPESCRIPT
? STORY_FORMAT.CSF_TYPESCRIPT
: STORY_FORMAT.CSF;

2
lib/cli/src/project_types.js
View File

@ -29,7 +29,7 @@ export const STORY_FORMAT = {
MDX: 'mdx',
};
export const supportedLanguages = {
export const SUPPORTED_LANGUAGES = {
JAVASCRIPT: 'javascript',
TYPESCRIPT: 'typescript',
};