GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-03 05:04:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10101 from davidcsally/allow-undefined-knobs

Browse Source 
Addon-knobs: Allow `text` and `number` to take undefined values
This commit is contained in:
Michael Shilman 2020-04-01 09:07:30 +08:00 committed by GitHub
commit c5bd44f1e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
addons/knobs/src/components/types/Number.tsx
View File

@ -14,11 +14,8 @@ export interface NumberTypeKnobOptions {
step?: number;
}
export interface NumberTypeKnob
extends KnobControlConfig<NumberTypeKnobValue>,
NumberTypeKnobOptions {
value: NumberTypeKnobValue;
}
export type NumberTypeKnob = KnobControlConfig<NumberTypeKnobValue> &
NumberTypeKnobOptions & { value?: NumberTypeKnobValue };
interface NumberTypeProps extends KnobControlProps<NumberTypeKnobValue | null> {
knob: NumberTypeKnob;

2
addons/knobs/src/components/types/Text.tsx
View File

@ -5,7 +5,7 @@ import { Form } from '@storybook/components';
import { KnobControlConfig, KnobControlProps } from './types';
type TextTypeKnobValue = string;
export type TextTypeKnob = KnobControlConfig<TextTypeKnobValue>;
export type TextTypeKnob = KnobControlConfig<TextTypeKnobValue> & { value?: TextTypeKnobValue };
type TextTypeProps = KnobControlProps<TextTypeKnobValue>;
export default class TextType extends Component<TextTypeProps> {