GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 08:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix linting issues

Browse Source
This commit is contained in:
Norbert de Langen 2022-04-05 11:03:49 +02:00
parent 20114ab68b
commit c4ec87721d
No known key found for this signature in database
GPG Key ID: FD0E78AF9A837762
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/theming/src/tests/create.test.js
View File

@ -56,7 +56,13 @@ describe('create brand', () => {
expect(result.brandTarget).not.toBeDefined(); expect(result.brandTarget).not.toBeDefined();
}); });
it('should accept null', () => { it('should accept null', () => {
const result = create({ base: 'light', brandTitle: null, brandUrl: null, brandImage: null, brandTarget: null }); const result = create({
base: 'light',
brandTitle: null,
brandUrl: null,
brandImage: null,
brandTarget: null,
});
expect(result).toMatchObject({ expect(result).toMatchObject({
brandImage: null, brandImage: null,

2
lib/ui/src/components/sidebar/Brand.tsx
View File

@ -33,7 +33,7 @@ export const LogoLink = styled.a(({ theme }) => ({
export const Brand = withTheme(({ theme }) => { export const Brand = withTheme(({ theme }) => {
const { title = 'Storybook', url = './', image, target } = theme.brand; const { title = 'Storybook', url = './', image, target } = theme.brand;
const targetValue = target ? target : (url === './' ? '' : '_blank'); const targetValue = target || (url === './' ? '' : '_blank');
// When image is explicitly set to null, enable custom HTML support // When image is explicitly set to null, enable custom HTML support
if (image === null) { if (image === null) {