GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-08 11:11:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Core: Pass args first to stories by default

Browse Source
This commit is contained in:
Michael Shilman 2020-04-17 01:53:27 +08:00
parent 1f27b252a6
commit c3e848b542
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
examples/official-storybook/stories/addon-docs/csf-with-mdx-docs.stories.js
View File

@ -7,5 +7,4 @@ export default {
includeStories: [], // or don't load this file at all
};
// eslint-disable-next-line react/prop-types
export const basic = ({ parameters }) => <Button>Basic</Button>;
export const basic = () => <Button>Basic</Button>;

1
examples/official-storybook/stories/core/globalArgs.stories.js
View File

@ -27,6 +27,7 @@ const ArgUpdater = ({ args, updateArgs }) => {
export default {
title: 'Core/Global Args',
parameters: { passArgsFirst: false },
decorators: [
(story) => {
const [globalArgs, updateGlobalArgs] = useGlobalArgs();

2
examples/riot-kitchen-sink/src/stories/core.stories.js
View File

@ -21,7 +21,7 @@ export default {
},
};
export const PassedToStory = ({ parameters: { fileName, ...parameters } }) =>
export const PassedToStory = (_args, { parameters: { fileName, ...parameters } }) =>
mount('parameters', { ...parameters, storyParameter });
PassedToStory.story = {

2
examples/vue-kitchen-sink/src/stories/core.stories.js
View File

@ -13,7 +13,7 @@ export default {
},
};
export const PassedToStory = ({ parameters: { fileName, ...parameters } }) => ({
export const PassedToStory = (_args, { parameters: { fileName, ...parameters } }) => ({
template: `<div>Parameters are <pre>${JSON.stringify(parameters, null, 2)}</pre></div>`,
});

3
lib/client-api/src/story_store.ts
View File

@ -298,7 +298,8 @@ export default class StoryStore {
);
let finalStoryFn: LegacyStoryFn;
if (parameters.passArgsFirst) {
const { passArgsFirst } = parameters;
if (passArgsFirst || typeof passArgsFirst === 'undefined') {
finalStoryFn = (context: StoryContext) => (original as ArgsStoryFn)(context.args, context);
} else {
finalStoryFn = original as LegacyStoryFn;