GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 10:11:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19651 from storybookjs/kasper/fix-storyobj-type

Browse Source 
CSF: Fix `StoryObj<typeof Cmp>` to work the same as old ComponentStoryObj
This commit is contained in:
Michael Shilman 2022-10-27 23:40:40 +08:00 committed by GitHub
commit c3d86a2abe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/renderers/react/src/public-types.test.tsx
View File

@ -79,7 +79,7 @@ describe('Args can be provided in multiple ways', () => {
});
test('Component can be used as generic parameter for StoryObj', () => {
type Expected = ReactStory<ButtonProps, ButtonProps>;
type Expected = ReactStory<ButtonProps, Partial<ButtonProps>>;
expectTypeOf<StoryObj<typeof Button>>().toEqualTypeOf<Expected>();
});
});

6
code/renderers/react/src/public-types.ts
View File

@ -53,11 +53,7 @@ export type StoryObj<TMetaOrCmpOrArgs = Args> = TMetaOrCmpOrArgs extends {
>
: never
: TMetaOrCmpOrArgs extends ComponentType<any>
? StoryAnnotations<
ReactFramework,
ComponentProps<TMetaOrCmpOrArgs>,
ComponentProps<TMetaOrCmpOrArgs>
>
? StoryAnnotations<ReactFramework, ComponentProps<TMetaOrCmpOrArgs>>
: StoryAnnotations<ReactFramework, TMetaOrCmpOrArgs>;
type ActionArgs<RArgs> = {

2
code/renderers/svelte/src/public-types.test.ts
View File

@ -141,7 +141,7 @@ describe('StoryObj', () => {
SvelteStory<
Button,
{ disabled: boolean; label: string },
{ disabled: boolean; label: string }
{ disabled?: boolean; label?: string }
>
>();
});

6
code/renderers/svelte/src/public-types.ts
View File

@ -49,11 +49,7 @@ export type StoryObj<MetaOrCmpOrArgs = Args> = MetaOrCmpOrArgs extends {
>
: never
: MetaOrCmpOrArgs extends SvelteComponentTyped
? StoryAnnotations<
SvelteFramework<MetaOrCmpOrArgs>,
ComponentProps<MetaOrCmpOrArgs>,
ComponentProps<MetaOrCmpOrArgs>
>
? StoryAnnotations<SvelteFramework<MetaOrCmpOrArgs>, ComponentProps<MetaOrCmpOrArgs>>
: StoryAnnotations<SvelteFramework, MetaOrCmpOrArgs>;
export type DecoratorFn<TArgs = Args> = DecoratorFunction<SvelteFramework, TArgs>;