Review PR

.circleci/config.yml

@@ -138,7 +138,6 @@ jobs:
       - persist_to_workspace:
           root: .
           paths:
-            - code/.nx/cache
             - code/node_modules
             - scripts/node_modules
             - code/examples

code/.yarnrc.yml

@@ -22,6 +22,7 @@ plugins:
   - path: ../.yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
     spec: '@yarnpkg/plugin-workspace-tools'
 
+# See https://github.com/nrwl/nx/issues/22177
 supportedArchitectures:
   cpu:
     - x64

code/frameworks/angular/tsconfig.build.json

@@ -4,6 +4,7 @@
   "compilerOptions": {
     "target": "ES2020",
     "module": "CommonJS",
+    "lib": ["es2020", "dom", "dom.iterable"],
     "experimentalDecorators": true,
     "emitDecoratorMetadata": true,
     "declaration": true,

code/frameworks/html-vite/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "resolveJsonModule": true,
     "strict": true

code/frameworks/preact-vite/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "resolveJsonModule": true,
     "jsx": "react-jsx",

code/frameworks/react-vite/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "resolveJsonModule": true,
     "strict": true

code/frameworks/svelte-vite/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "resolveJsonModule": true,
     "strict": true

code/frameworks/sveltekit/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "resolveJsonModule": true,
     "strict": true

code/frameworks/vue3-vite/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "skipLibCheck": true,
     "resolveJsonModule": true,

code/frameworks/web-components-vite/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "rootDir": "./src",
     "types": ["node"],
     "resolveJsonModule": true,
     "strict": true

code/nx.json

@@ -33,21 +33,6 @@
     }
   },
   "targetDefaults": {
-    "install": {
-      "executor": "nx:run-commands",
-      "options": {
-        "commands": [
-          {
-            "prefix": "workspace",
-            "command": "yarn"
-          },
-          {
-            "prefix": "scripts",
-            "command": "yarn --cwd ../scripts"
-          }
-        ]
-      }
-    },
     "build": {
       "executor": "nx:run-commands",
       "options": {

code/project.json

@@ -1,7 +0,0 @@
-{
-  "name": "root",
-  "projectType": "library",
-  "targets": {
-    "install": {}
-  }
-}

code/vitest.workspace.ts

@@ -24,9 +24,6 @@ const threadCount = process.env.CI ? 8 : undefined;
 
 export const vitestCommonConfig = defineConfig({
   test: {
-    cache: {
-      dir: './node_modules/.vitest',
-    },
     clearMocks: true,
     setupFiles: [resolve(__dirname, './vitest-setup.ts')],
     globals: true,