GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 20:41:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
This commit is contained in:
Norbert de Langen 2022-11-24 13:00:11 +01:00 committed by GitHub
parent 2d3fd3606d
commit bf5f7831d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
14 changed files with 22 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/addons/storyshots/storyshots-core/src/frameworks/angular/loader.ts
View File

@ -36,10 +36,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/html/loader.ts
View File

@ -13,10 +13,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/preact/loader.ts
View File

@ -19,10 +19,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

2
code/addons/storyshots/storyshots-core/src/frameworks/rax/loader.ts
View File

@ -14,7 +14,7 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...coreClientAPI,

4
code/addons/storyshots/storyshots-core/src/frameworks/react/loader.ts
View File

@ -11,10 +11,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/riot/loader.ts
View File

@ -19,10 +19,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/svelte/loader.ts
View File

@ -16,10 +16,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/vue/loader.ts
View File

@ -19,10 +19,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/vue3/loader.ts
View File

@ -14,10 +14,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

4
code/addons/storyshots/storyshots-core/src/frameworks/web-components/loader.ts
View File

@ -13,10 +13,10 @@ function load(options: StoryshotsOptions) {
let mockStartedAPI: any; let mockStartedAPI: any;
jest.mock('@storybook/preview-api', () => { jest.mock('@storybook/preview-api', () => {
const coreClientAPI = jest.requireActual('@storybook/preview-api'); const previewAPI = jest.requireActual('@storybook/preview-api');
return { return {
...coreClientAPI, ...previewAPI,
start: (...args: any[]) => { start: (...args: any[]) => {
mockStartedAPI = coreClientAPI.start(...args); mockStartedAPI = coreClientAPI.start(...args);
return mockStartedAPI; return mockStartedAPI;

1
code/frameworks/nextjs/package.json
View File

@ -59,7 +59,6 @@
"prep": "../../../scripts/prepare/bundle.ts" "prep": "../../../scripts/prepare/bundle.ts"
}, },
"dependencies": { "dependencies": {
"@babel/preset-typescript": "^7.18.6",
"@storybook/addons": "7.0.0-alpha.52", "@storybook/addons": "7.0.0-alpha.52",
"@storybook/builder-webpack5": "7.0.0-alpha.52", "@storybook/builder-webpack5": "7.0.0-alpha.52",
"@storybook/core-common": "7.0.0-alpha.52", "@storybook/core-common": "7.0.0-alpha.52",

4
code/lib/preview-api/src/modules/preview-web/docs-context/DocsContextProps.ts
View File

@ -1,3 +1 @@
import type { DocsContextProps } from '@storybook/types'; export type { DocsContextProps } from '@storybook/types';
export { DocsContextProps };

4
code/lib/preview-api/src/modules/preview-web/docs-context/DocsRenderFunction.ts
View File

@ -1,3 +1 @@
import type { DocsRenderFunction } from '@storybook/types'; export type { DocsRenderFunction } from '@storybook/types';
export type { DocsRenderFunction };

2
code/lib/preview-api/src/modules/store/decorators.test.ts
View File

@ -92,7 +92,7 @@ describe('client-api.decorators', () => {
// the same story twice at the same time. // the same story twice at the same time.
it('does not interleave contexts if two decorated stories are call simultaneously', async () => { it('does not interleave contexts if two decorated stories are call simultaneously', async () => {
const contexts: StoryContext[] = []; const contexts: StoryContext[] = [];
let resolve: any; let resolve: (value: unknown) => void;
const fence = new Promise((r) => { const fence = new Promise((r) => {
resolve = r; resolve = r;
}); });