GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 22:11:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19585 from LBBO/19420-init-remove-deprecated-s-flag

Browse Source 
CLI: Remove deprecated `-s` flag on `sb init`
This commit is contained in:
Michael Shilman 2022-11-03 01:28:34 +08:00 committed by GitHub
commit b9af9f72af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
code/lib/cli/src/generators/baseGenerator.ts
View File

@ -1,3 +1,4 @@
import path from 'path';
import fse from 'fs-extra';
import { dedent } from 'ts-dedent';
import type { NpmOptions } from '../NpmOptions';
@ -195,6 +196,7 @@ export async function baseGenerator(
addons: pnp ? addons.map(wrapForPnp) : addons,
extensions,
commonJs,
...(staticDir ? { staticDirs: [path.join('..', staticDir)] } : null),
...extraMain,
...(type !== 'framework'
? {
@ -235,7 +237,6 @@ export async function baseGenerator(
if (addScripts) {
packageManager.addStorybookCommandInScripts({
port: 6006,
staticFolder: staticDir,
});
}

3
code/lib/cli/src/generators/configure.ts
View File

@ -6,13 +6,14 @@ interface ConfigureMainOptions {
addons: string[];
extensions?: string[];
commonJs?: boolean;
staticDirs?: string[];
/**
* Extra values for main.js
*
* In order to provide non-serializable data like functions, you can use
* { value: '%%yourFunctionCall()%%' }
*
* '%% and %%' will be replace.
* '%% and %%' will be replaced.
*
*/
[key: string]: any;

14
code/lib/cli/src/js-package-manager/JsPackageManager.ts
View File

@ -304,19 +304,11 @@ export abstract class JsPackageManager {
return versions.reverse().find((version) => satisfies(version, constraint));
}
public addStorybookCommandInScripts(options?: {
port: number;
staticFolder?: string;
preCommand?: string;
}) {
public addStorybookCommandInScripts(options?: { port: number; preCommand?: string }) {
const sbPort = options?.port ?? 6006;
const storybookCmd = options?.staticFolder
? `storybook dev -p ${sbPort} -s ${options.staticFolder}`
: `storybook dev -p ${sbPort}`;
const storybookCmd = `storybook dev -p ${sbPort}`;
const buildStorybookCmd = options?.staticFolder
? `storybook build -s ${options.staticFolder}`
: `storybook build`;
const buildStorybookCmd = `storybook build`;
const preCommand = options?.preCommand ? this.getRunCommand(options.preCommand) : undefined;
this.addScripts({