GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-03-17 05:02:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13303 from storybookjs/fix/fastRefreshCRA

Browse Source 
React: Don't add FastRefresh if already enabled
This commit is contained in:
Michael Shilman 2020-11-27 09:32:00 +08:00 committed by GitHub
commit b4660060c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/react/src/server/framework-preset-react.ts
View File

@ -18,7 +18,10 @@ export async function babel(config: TransformOptions, options: StorybookOptions)
return {
...config,
plugins: [require.resolve('react-refresh/babel'), ...(config.plugins || [])],
plugins: [
[require.resolve('react-refresh/babel'), {}, 'storybook-react-refresh'],
...(config.plugins || []),
],
};
}
const storybookReactDirName = path.dirname(require.resolve('@storybook/react/package.json'));
@ -58,8 +61,16 @@ export async function webpackFinal(config: Configuration, options: StorybookOpti
if (!fastRefreshEnabled) {
return config;
}
// matches the name of the plugin in CRA.
const hasReactRefresh = config.plugins.find((p) => p.constructor.name === 'ReactRefreshPlugin');
if (hasReactRefresh) {
logger.warn("=> React refresh is already set. You don't need to set the option");
return config;
}
logger.info('=> Using React fast refresh');
return {
...config,
plugins: [...(config.plugins || []), new ReactRefreshWebpackPlugin()],