GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 15:11:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Verify that name is a string in addons/actions

Browse Source 
It appears that it’s possible that `name` can be passed in
as an object. In order for the `replace` method to work,
name must be a string. This pull request adds a condition to
the `fnName` constant that verifies the value of `name` is
a string.
This commit is contained in:
Tom Cunningham 2017-07-05 12:02:30 -05:00
parent acfddc052b
commit b3d79a5eda
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
addons/actions/src/preview.js
View File

@ -30,7 +30,7 @@ export function action(name) {
// the same.
//
// Ref: https://bocoup.com/weblog/whats-in-a-function-name
const fnName = name ? name.replace(/\W+/g, '_') : 'action';
const fnName = name && typeof name === 'string' ? name.replace(/\W+/g, '_') : 'action';
// eslint-disable-next-line no-eval
const named = eval(`(function ${fnName}() { return handler.apply(this, arguments) })`);
return named;