GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 08:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't notify user on patch/prerelease versions

Browse Source
This commit is contained in:
Michael Shilman 2019-03-18 16:34:53 +08:00
parent 839f798ed2
commit b0f52c27bc
2 changed files with 37 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/ui/src/core/versions.js
View File

@ -80,7 +80,11 @@ export default function({ store }) {
if (versionUpdateAvailable()) {
const latestVersion = getLatestVersion().version;
if (latestVersion !== dismissedVersionNotification) {
if (
latestVersion !== dismissedVersionNotification &&
!semver.patch(latestVersion) &&
!semver.prerelease(latestVersion)
) {
addNotification({
id: 'update',
link: '/settings/about',

50
lib/ui/src/core/versions.test.js
View File

@ -38,6 +38,7 @@ const makeResponse = (latest, next) => {
const newResponse = makeResponse('4.0.0', null);
const oldResponse = makeResponse('2.0.0', null);
const prereleaseResponse = makeResponse('3.0.0', '4.0.0-alpha.0');
const patchResponse = makeResponse('3.0.1', '4.0.0-alpha.0');
jest.mock('@storybook/client-logger');
@ -138,27 +139,40 @@ describe('versions API', () => {
});
});
it('sets an update notification right away in the init function', async () => {
const store = createMockStore();
const { init, api, state: initialState } = initVersions({ store });
store.setState(initialState);
describe('notifications', () => {
it('sets an update notification right away in the init function', async () => {
const store = createMockStore();
const { init, api, state: initialState } = initVersions({ store });
store.setState(initialState);
fetch.mockResolvedValueOnce(newResponse);
const addNotification = jest.fn();
await init({ api: { addNotification, ...api } });
expect(addNotification).toHaveBeenCalled();
});
fetch.mockResolvedValueOnce(newResponse);
const addNotification = jest.fn();
await init({ api: { addNotification, ...api } });
expect(addNotification).toHaveBeenCalled();
});
it('does not set an update notification if it has been dismissed', async () => {
const store = createMockStore();
store.setState({ dismissedVersionNotification: '4.0.0' });
const { init, api, state: initialState } = initVersions({ store });
store.setState(initialState);
it('does not set an update notification if it has been dismissed', async () => {
const store = createMockStore();
store.setState({ dismissedVersionNotification: '4.0.0' });
const { init, api, state: initialState } = initVersions({ store });
store.setState(initialState);
fetch.mockResolvedValueOnce(newResponse);
const addNotification = jest.fn();
await init({ api: { addNotification, ...api } });
expect(addNotification).not.toHaveBeenCalled();
fetch.mockResolvedValueOnce(newResponse);
const addNotification = jest.fn();
await init({ api: { addNotification, ...api } });
expect(addNotification).not.toHaveBeenCalled();
});
it('does not set an update notification if the latest version is a patch', async () => {
const store = createMockStore();
const { init, api, state: initialState } = initVersions({ store });
store.setState(initialState);
fetch.mockResolvedValueOnce(patchResponse);
const addNotification = jest.fn();
await init({ api: { addNotification, ...api } });
expect(addNotification).not.toHaveBeenCalled();
});
});
it('persists a dismissed notification', async () => {