GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 00:41:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't append title prefix to Meta of= docs entries

Browse Source
This commit is contained in:
Tom Coleman 2022-07-06 12:07:10 +10:00
parent e19e16c090
commit abd94041a6
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/core-server/src/utils/StoryIndexGenerator.test.ts
View File

@ -525,6 +525,33 @@ describe('StoryIndexGenerator', () => {
`);
});
it('does not append title prefix if meta references a CSF file', async () => {
const generator = new StoryIndexGenerator(
[
storiesSpecifier,
normalizeStoriesEntry(
{ directory: './src/docs2', files: '**/*.mdx', titlePrefix: 'titlePrefix' },
options
),
],
options
);
await generator.initialize();
// NOTE: `toMatchInlineSnapshot` on objects sorts the keys, but in actuality, they are
// not sorted by default.
expect(Object.values((await generator.getIndex()).entries).map((e) => e.title))
.toMatchInlineSnapshot(`
Array [
"A",
"A",
"titlePrefix/NoTitle",
"A",
"titlePrefix/docs2/Yabbadabbadooo",
]
`);
});
it('generates no docs entries when docs are disabled', async () => {
const generator = new StoryIndexGenerator([storiesSpecifier, docsSpecifier], {
...options,

2
lib/core-server/src/utils/StoryIndexGenerator.ts
View File

@ -307,7 +307,7 @@ export class StoryIndexGenerator {
dep.dependents.push(absolutePath);
});
const title = userOrAutoTitleFromSpecifier(importPath, specifier, result.title || ofTitle);
const title = ofTitle || userOrAutoTitleFromSpecifier(importPath, specifier, result.title);
const name = result.name || this.options.docs.defaultName;
const id = toId(title, name);