GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 19:11:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11920 from storybookjs/119124-fix-source-loader-adds

Browse Source 
Source-loader: Fix `.add` detection
This commit is contained in:
Michael Shilman 2020-08-12 16:51:07 +08:00 committed by GitHub
commit a63f0f0987
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
__mocks__/inject-parameters.ts.csf.txt
View File

@ -27,4 +27,11 @@ export const WithTemplate = Template.bind({});
WithTemplate.args = { foo: 'bar' }
export const WithEmptyTemplate = Template.bind();
WithEmptyTemplate.args = { foo: 'baz' };
WithEmptyTemplate.args = { foo: 'baz' };
export const WithAddFunctionParameters = () => null
WithAddFunctionParameters.parameters = {
foobar: () => {
document.addEventListener('foo', () => console.log('bar'))
},
}

3
lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.snap
View File

@ -9,7 +9,8 @@ WithParams.parameters = { storySource: { source: \\"() => <Button>WithParams</Bu
WithDocsParams.parameters = { storySource: { source: \\"() => <Button>WithDocsParams</Button>\\" }, ...WithDocsParams.parameters };
WithStorySourceParams.parameters = { storySource: { source: \\"() => <Button>WithStorySourceParams</Button>\\" }, ...WithStorySourceParams.parameters };
WithTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithTemplate.parameters };
WithEmptyTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithEmptyTemplate.parameters };"
WithEmptyTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithEmptyTemplate.parameters };
WithAddFunctionParameters.parameters = { storySource: { source: \\"() => null\\" }, ...WithAddFunctionParameters.parameters };"
`;
exports[`inject-decorator positive - ts - csf includes storySource parameter in the default exported object 1`] = `

2
lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
View File

@ -103,7 +103,7 @@ export function handleExportedName(storyName, originalNode, parent) {
}
export function handleADD(node, parent, storiesOfIdentifiers) {
if (!node.property || !node.property.name || node.property.name.indexOf('add') !== 0) {
if (!node.property || !node.property.name || node.property.name !== 'add') {
return {};
}