improve vue integration

addons/storyshots/storyshots-core/src/frameworks/vue/renderTree.js

@@ -2,12 +2,15 @@
 import Vue from 'vue';
 
 function getRenderedTree(story, context) {
-  const storyElement = story.render(context);
+  const component = story.render(context);
 
-  const Constructor = Vue.extend(storyElement);
-  const vm = new Constructor().$mount();
+  const vm = new Vue({
+    render(h) {
+      return h(component);
+    },
+  });
 
-  return vm.$el;
+  return vm.$mount().$el;
 }
 
 export default getRenderedTree;

app/vue/src/client/preview/index.js

@@ -1,30 +1,72 @@
 import { start } from '@storybook/core/client';
+import Vue from 'vue';
 
 import './globals';
 import render from './render';
 
-const createWrapperComponent = Target => ({
-  functional: true,
-  render(h, c) {
-    return h(Target, c.data, c.children);
-  },
-});
-const decorateStory = (getStory, decorators) =>
-  decorators.reduce(
-    (decorated, decorator) => context => {
-      const story = () => decorated(context);
-      let decoratedStory = decorator(story, context);
+export const WRAPS = 'STORYBOOK_WRAPS';
+export const VALUES = 'STORYBOOK_VALUES';
 
-      if (typeof decoratedStory === 'string') {
-        decoratedStory = { template: decoratedStory };
+function extractProps(component) {
+  return Object.entries(component.options.props || {})
+    .map(([name, def]) => ({ [name]: def.default }))
+    .reduce((wrap, prop) => ({ ...wrap, ...prop }), {});
+}
+
+function prepare(rawStory, innerStory) {
+  let story = rawStory;
+  // eslint-disable-next-line no-underscore-dangle
+  if (!story._isVue) {
+    if (typeof story === 'string') {
+      story = { template: story };
+    }
+    if (innerStory) {
+      story.components = { ...(story.components || {}), story: innerStory };
+    }
+    story = Vue.extend(story);
+  } else if (story.options[WRAPS]) {
+    return story;
   }
 
-      decoratedStory.components = decoratedStory.components || {};
-      decoratedStory.components.story = createWrapperComponent(story());
-      return decoratedStory;
+  return Vue.extend({
+    [WRAPS]: story,
+    [VALUES]: { ...(innerStory ? innerStory.options[VALUES] : {}), ...extractProps(story) },
+    functional: true,
+    render(h, { data, parent, children }) {
+      return h(
+        story,
+        {
+          ...data,
+          props: { ...(data.props || {}), ...(parent.$root[VALUES] || {}) },
         },
-    getStory
+        children
       );
+    },
+  });
+}
+
+function decorateStory(getStory, decorators) {
+  return decorators.reduce(
+    (decorated, decorator) => context => {
+      let story;
+      const decoratedStory = decorator(() => {
+        story = decorated(context);
+        return story;
+      }, context);
+
+      if (!story) {
+        story = decorated(context);
+      }
+
+      if (decoratedStory === story) {
+        return story;
+      }
+
+      return prepare(decoratedStory, story);
+    },
+    context => prepare(getStory(context))
+  );
+}
 
 const { clientApi, configApi, forceReRender } = start(render, { decorateStory });
 

app/vue/src/client/preview/render.js

@@ -1,24 +1,17 @@
 import { stripIndents } from 'common-tags';
 import Vue from 'vue';
+import { VALUES } from '.';
 
 let root = null;
 
-function getComponentProxy(component) {
-  return Object.entries(component.props || {})
-    .map(([name, def]) => ({ [name]: def.default }))
-    .reduce((wrap, prop) => ({ ...wrap, ...prop }), {});
-}
-
-function renderRoot(component, proxy) {
+function renderRoot(component) {
   root = new Vue({
     el: '#root',
-    beforeCreate() {
-      this.proxy = proxy;
+    data() {
+      return { [VALUES]: component.options[VALUES] };
     },
-
     render(h) {
-      const props = this.proxy;
-      return h('div', { attrs: { id: 'root' } }, [h(component, { props })]);
+      return h('div', { attrs: { id: 'root' } }, [h(component)]);
     },
   });
 }
@@ -49,15 +42,12 @@ export default function render({
 
   showMain();
 
-  const proxy = getComponentProxy(component);
-
   // at component creation || refresh by HMR
   if (!root || !forceRender) {
     if (root) root.$destroy();
 
-    renderRoot(component, proxy);
+    renderRoot(component);
   } else {
-    root.proxy = proxy;
-    root.$forceUpdate();
+    root[VALUES] = component.options[VALUES];
   }
 }

examples/vue-kitchen-sink/src/stories/__snapshots__/addon-centered.stories.storyshot

@@ -4,18 +4,6 @@ exports[`Storyshots Addon|Centered rounded 1`] = `
 <div
   style="position: fixed; top: 0px; left: 0px; bottom: 0px; right: 0px; display: flex; align-items: center; overflow: auto;"
 >
-  <div
-    style="margin: auto; max-height: 100%;"
-  >
-    <div
-      style="position: fixed; top: 0px; left: 0px; bottom: 0px; right: 0px; display: flex; align-items: center; overflow: auto;"
-    >
-      <div
-        style="margin: auto; max-height: 100%;"
-      >
-        <div
-          style="position: fixed; top: 0px; left: 0px; bottom: 0px; right: 0px; display: flex; align-items: center; overflow: auto;"
-        >
   <div
     style="margin: auto; max-height: 100%;"
   >
@@ -26,9 +14,5 @@ exports[`Storyshots Addon|Centered rounded 1`] = `
       A Button with rounded edges!
     </button>
   </div>
-        </div>
-      </div>
-    </div>
-  </div>
 </div>
 `;

examples/vue-kitchen-sink/src/stories/__snapshots__/custom-decorators.stories.storyshot

@@ -4,12 +4,6 @@ exports[`Storyshots Custom|Decorator for Vue render 1`] = `
 <div
   style="border: medium solid blue;"
 >
-  <div
-    style="border: medium solid blue;"
-  >
-    <div
-      style="border: medium solid blue;"
-    >
   <div
     style="border: medium solid red;"
   >
@@ -19,8 +13,6 @@ exports[`Storyshots Custom|Decorator for Vue render 1`] = `
       renders component: MyButton!
     </button>
   </div>
-    </div>
-  </div>
 </div>
 `;
 
@@ -28,12 +20,6 @@ exports[`Storyshots Custom|Decorator for Vue template 1`] = `
 <div
   style="border: medium solid blue;"
 >
-  <div
-    style="border: medium solid blue;"
-  >
-    <div
-      style="border: medium solid blue;"
-    >
   <div
     style="border: medium solid red;"
   >
@@ -44,7 +30,5 @@ exports[`Storyshots Custom|Decorator for Vue template 1`] = `
       MyButton with template!
     </button>
   </div>
-    </div>
-  </div>
 </div>
 `;