fixes

code/builders/builder-manager/src/index.ts

@@ -41,8 +41,6 @@ export const getConfig: ManagerBuilder['getConfig'] = async (options) => {
     ? [...addonsEntryPoints, customManagerEntryPoint]
     : addonsEntryPoints;
 
-  console.log(globalExternals(globalsModuleInfoMap));
-
   return {
     entryPoints: await wrapManagerEntries(entryPoints, options.cacheKey),
     outdir: join(options.outputDir || './', 'sb-addons'),
@@ -72,7 +70,7 @@ export const getConfig: ManagerBuilder['getConfig'] = async (options) => {
     target: ['chrome100', 'safari15', 'firefox91'],
     platform: 'browser',
     bundle: true,
-    minify: true,
+    minify: false,
     sourcemap: false,
     conditions: ['browser', 'module', 'default'],
 

code/core/scripts/entries.ts

@@ -56,7 +56,7 @@ export const getEntries = (cwd: string) => {
   ];
 };
 
-// these entries explicitly bundle everything INCLUDING `@storybook/core` itself.
+// entries for injecting globals into the preview and manager
 export const getBundles = (cwd: string) => {
   const define = defineEntry(cwd);
 
@@ -64,6 +64,15 @@ export const getBundles = (cwd: string) => {
     //
     define('src/preview/runtime.ts', ['browser'], false),
     define('src/manager/globals-runtime.ts', ['browser'], false),
+  ];
+};
+
+// the runtime for the manager
+export const getFinals = (cwd: string) => {
+  const define = defineEntry(cwd);
+
+  return [
+    //
     define('src/manager/runtime.ts', ['browser'], false),
   ];
 };

code/core/scripts/prep.ts

@@ -15,8 +15,11 @@ import {
   sortPackageJson,
   limit,
   Bun,
+  globalExternals,
 } from '../../../scripts/prepare/tools';
-import { getBundles, getEntries } from './entries';
+import { getBundles, getEntries, getFinals } from './entries';
+
+import { globalsModuleInfoMap } from '../src/manager/globals-module-info';
 
 import pkg from '../package.json';
 import { generateSourceFiles } from './helpers/sourcefiles';
@@ -45,6 +48,7 @@ if (isReset) {
 
 const entries = getEntries(cwd);
 const bundles = getBundles(cwd);
+const finals = getFinals(cwd);
 
 type EsbuildContextOptions = Parameters<(typeof esbuild)['context']>[0];
 
@@ -149,14 +153,48 @@ async function generateDistFiles() {
           merge<EsbuildContextOptions>(esbuildDefaultOptions, {
             format: 'esm',
             target: 'chrome100',
-            splitting: true,
+            splitting: false,
             // platform: 'browser',
             outdir: dirname(entry.file).replace('src', 'dist'),
             entryPoints: [entry.file],
             conditions: ['browser', 'module', 'import', 'default'],
             outExtension: { '.js': '.js' },
+            // define: {
+            //   'process.env.NODE_ENV': JSON.stringify('production'),
+            // },
             alias: {
               '@storybook/core/dist': join(cwd, 'src'),
+              react: dirname(require.resolve('react/package.json')),
+              'react-dom': dirname(require.resolve('react-dom/package.json')),
+            },
+            external: [],
+          })
+        )
+      );
+
+      return results;
+    }),
+    ...finals.flatMap((entry) => {
+      const results = [];
+      results.push(
+        esbuild.context(
+          merge<EsbuildContextOptions>(esbuildDefaultOptions, {
+            format: 'esm',
+            target: 'chrome100',
+            splitting: false,
+            // platform: 'browser',
+            outdir: dirname(entry.file).replace('src', 'dist'),
+            entryPoints: [entry.file],
+            conditions: ['browser', 'module', 'import', 'default'],
+            outExtension: { '.js': '.js' },
+            define: {
+              'process.env.NODE_ENV': JSON.stringify('production'),
+            },
+            plugins: [globalExternals(globalsModuleInfoMap)],
+            alias: {
+              '@storybook/core/dist': join(cwd, 'src'),
+              react: dirname(require.resolve('react/package.json')),
+              'react-dom': dirname(require.resolve('react-dom/package.json')),
             },
             external: [],
           })

code/core/src/manager/globals/runtime.ts

@@ -1,5 +1,5 @@
 import * as REACT from 'react';
-import * as REACT_DOM from 'react-dom';
+import * as REACT_DOM from 'react-dom/client';
 
 import * as COMPONENTS from '@storybook/core/dist/components';
 import * as ICONS from '@storybook/icons';

code/ui/.storybook/main.ts

@@ -7,7 +7,7 @@ const isBlocksOnly = process.env.STORYBOOK_BLOCKS_ONLY === 'true';
 
 const allStories = [
   {
-    directory: '../manager/src',
+    directory: '../../core/src/manager',
     titlePrefix: '@manager',
   },
   {
@@ -15,7 +15,7 @@ const allStories = [
     titlePrefix: '@preview',
   },
   {
-    directory: '../components/src/components',
+    directory: '../../core/src/components',
     titlePrefix: '@components',
   },
   {

scripts/package.json

@@ -71,6 +71,7 @@
     "@babel/preset-react": "^7.22.15",
     "@babel/preset-typescript": "^7.23.2",
     "@babel/types": "^7.23.0",
+    "@fal-works/esbuild-plugin-global-externals": "^2.1.2",
     "@google-cloud/bigquery": "^6.2.0",
     "@nx/workspace": "18.0.6",
     "@octokit/graphql": "^5.0.5",

scripts/prepare/tools.ts

@@ -5,9 +5,13 @@ import Bun from 'bun';
 
 import slash from 'slash';
 
+import { globalExternals } from '@fal-works/esbuild-plugin-global-externals';
+
 import * as rpd from 'rollup-plugin-dts';
 import * as rollup from 'rollup';
 
+export { globalExternals };
+
 export const dts = async (entry: string, externals: string[], tsconfig: string) => {
   console.log(entry);
   const dir = dirname(entry).replace('src', 'dist');

scripts/yarn.lock

@@ -1693,6 +1693,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@fal-works/esbuild-plugin-global-externals@npm:^2.1.2":
+  version: 2.1.2
+  resolution: "@fal-works/esbuild-plugin-global-externals@npm:2.1.2"
+  checksum: 10c0/2c84a8e6121b00ac8e4eb2469ab8f188142db2f1927391758e5d0142cb684b7eb0fad0c9d6caf358616eb2a77af2c067e08b9ec8e05749b415fc4dd0ef96d0fe
+  languageName: node
+  linkType: hard
+
 "@fastify/busboy@npm:^2.0.0":
   version: 2.0.0
   resolution: "@fastify/busboy@npm:2.0.0"
@@ -2747,6 +2754,7 @@ __metadata:
     "@babel/preset-react": "npm:^7.22.15"
     "@babel/preset-typescript": "npm:^7.23.2"
     "@babel/types": "npm:^7.23.0"
+    "@fal-works/esbuild-plugin-global-externals": "npm:^2.1.2"
     "@google-cloud/bigquery": "npm:^6.2.0"
     "@nx/workspace": "npm:18.0.6"
     "@octokit/graphql": "npm:^5.0.5"