From 98c7c573d69c31fa273efb29da3a3e4a15c9b94a Mon Sep 17 00:00:00 2001
From: Tom Coleman <tom@thesnail.org>
Date: Thu, 2 Jul 2020 20:04:07 +1000
Subject: [PATCH] Tests

---
 lib/api/src/tests/url.test.js | 41 ++++++++++++++---------------------
 1 file changed, 16 insertions(+), 25 deletions(-)

diff --git a/lib/api/src/tests/url.test.js b/lib/api/src/tests/url.test.js
index 064bd0488a6..2a77a44c30d 100644
--- a/lib/api/src/tests/url.test.js
+++ b/lib/api/src/tests/url.test.js
@@ -7,19 +7,6 @@ jest.useFakeTimers();
 describe('initial state', () => {
   const viewMode = 'story';
 
-  it('redirects to /story/* if path is blank', () => {
-    const navigate = jest.fn();
-    const location = { search: null };
-    const {
-      state: { layout },
-    } = initURL({ navigate, state: { location, viewMode } });
-
-    // Nothing unexpected in layout
-    expect(layout).toEqual({});
-    jest.runAllTimers();
-    expect(navigate).toHaveBeenCalledWith('/story/*', { replace: true });
-  });
-
   describe('config query parameters', () => {
     it('handles full parameter', () => {
       const navigate = jest.fn();
@@ -88,23 +75,29 @@ describe('initial state', () => {
       addonPanel: 'storybook%2Factions%2Factions-panel',
     };
 
-    it('handles defaults and routes to story', () => {
-      const navigate = jest.fn();
+    it('sets sensible storyId for selectedKind/Story', () => {
       const location = { search: qs.stringify(defaultLegacyParameters) };
       const {
-        state: { layout, selectedPanel },
-      } = initURL({ navigate, state: { location, viewMode } });
+        state: { layout, selectedPanel, storyId },
+      } = initURL({ state: { location, viewMode } });
 
       // Nothing unexpected in layout
       expect(layout).toEqual({});
       // TODO: at the very least this should be unescaped
       expect(selectedPanel).toEqual('storybook%2Factions%2Factions-panel');
-      jest.runAllTimers();
-      expect(navigate).toHaveBeenCalledWith('/story/kind--story', { replace: true });
+      expect(storyId).toEqual('kind--story');
+    });
+
+    it('sets sensible storyId for selectedKind only', () => {
+      const location = { search: { selectedKind: 'kind' } };
+      const {
+        state: { storyId },
+      } = initURL({ state: { location, viewMode } });
+
+      expect(storyId).toEqual('kind');
     });
 
     it('handles full parameter', () => {
-      const navigate = jest.fn();
       const location = {
         search: qs.stringify({
           ...defaultLegacyParameters,
@@ -113,13 +106,12 @@ describe('initial state', () => {
       };
       const {
         state: { layout },
-      } = initURL({ navigate, state: { location } });
+      } = initURL({ state: { location } });
 
       expect(layout).toEqual({ isFullscreen: true });
     });
 
     it('handles addons and stories parameters', () => {
-      const navigate = jest.fn();
       const location = {
         search: qs.stringify({
           ...defaultLegacyParameters,
@@ -129,13 +121,12 @@ describe('initial state', () => {
       };
       const {
         state: { layout },
-      } = initURL({ navigate, state: { location } });
+      } = initURL({ state: { location } });
 
       expect(layout).toEqual({ showNav: false, showPanel: false });
     });
 
     it('handles panelRight parameter', () => {
-      const navigate = jest.fn();
       const location = {
         search: qs.stringify({
           ...defaultLegacyParameters,
@@ -144,7 +135,7 @@ describe('initial state', () => {
       };
       const {
         state: { layout },
-      } = initURL({ navigate, state: { location } });
+      } = initURL({ state: { location } });
 
       expect(layout).toEqual({ panelPosition: 'right' });
     });