GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 16:11:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Log error in index

Browse Source
This commit is contained in:
Tom Coleman 2023-02-16 15:50:09 +11:00
parent 1b99fc225d
commit 978a0f53b6
1 changed files with 44 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
code/lib/core-server/src/utils/StoryIndexGenerator.ts
View File

@ -103,6 +103,9 @@ export class StoryIndexGenerator {
// - the preview changes [not yet implemented] // - the preview changes [not yet implemented]
private lastIndex?: StoryIndex; private lastIndex?: StoryIndex;
// Same as the above but for the error case
private lastError?: Error;
constructor( constructor(
public readonly specifiers: NormalizedStoriesSpecifier[], public readonly specifiers: NormalizedStoriesSpecifier[],
public readonly options: { public readonly options: {
@ -487,48 +490,56 @@ export class StoryIndexGenerator {
async getIndex() { async getIndex() {
if (this.lastIndex) return this.lastIndex; if (this.lastIndex) return this.lastIndex;
if (this.lastError) throw this.lastError;
// Extract any entries that are currently missing // Extract any entries that are currently missing
// Pull out each file's stories into a list of stories, to be composed and sorted // Pull out each file's stories into a list of stories, to be composed and sorted
const storiesList = await this.ensureExtracted(); const storiesList = await this.ensureExtracted();
const firstError = storiesList.find((entry) => entry.type === 'error'); try {
if (firstError) throw (firstError as ErrorEntry).err; const firstError = storiesList.find((entry) => entry.type === 'error');
if (firstError) throw (firstError as ErrorEntry).err;
const sorted = await this.sortStories(storiesList as IndexEntry[]); const sorted = await this.sortStories(storiesList as IndexEntry[]);
let compat = sorted; let compat = sorted;
if (this.options.storiesV2Compatibility) { if (this.options.storiesV2Compatibility) {
const titleToStoryCount = Object.values(sorted).reduce((acc, story) => { const titleToStoryCount = Object.values(sorted).reduce((acc, story) => {
acc[story.title] = (acc[story.title] || 0) + 1; acc[story.title] = (acc[story.title] || 0) + 1;
return acc; return acc;
}, {} as Record<ComponentTitle, number>); }, {} as Record<ComponentTitle, number>);
// @ts-expect-error (Converted from ts-ignore) // @ts-expect-error (Converted from ts-ignore)
compat = Object.entries(sorted).reduce((acc, entry) => { compat = Object.entries(sorted).reduce((acc, entry) => {
const [id, story] = entry; const [id, story] = entry;
if (story.type === 'docs') return acc; if (story.type === 'docs') return acc;
acc[id] = { acc[id] = {
...story, ...story,
kind: story.title, kind: story.title,
story: story.name, story: story.name,
parameters: { parameters: {
__id: story.id, __id: story.id,
docsOnly: titleToStoryCount[story.title] === 1 && story.name === 'Page', docsOnly: titleToStoryCount[story.title] === 1 && story.name === 'Page',
fileName: story.importPath, fileName: story.importPath,
}, },
}; };
return acc; return acc;
}, {} as Record<StoryId, V2CompatIndexEntry>); }, {} as Record<StoryId, V2CompatIndexEntry>);
}
this.lastIndex = {
v: 4,
entries: compat,
};
return this.lastIndex;
} catch (err) {
this.lastError = err;
logger.warn(`🚨 Couldn't fetch index`);
logger.warn(this.lastError.stack);
throw this.lastError;
} }
this.lastIndex = {
v: 4,
entries: compat,
};
return this.lastIndex;
} }
invalidate(specifier: NormalizedStoriesSpecifier, importPath: Path, removed: boolean) { invalidate(specifier: NormalizedStoriesSpecifier, importPath: Path, removed: boolean) {
@ -567,6 +578,7 @@ export class StoryIndexGenerator {
cache[absolutePath] = false; cache[absolutePath] = false;
} }
this.lastIndex = null; this.lastIndex = null;
this.lastError = null;
} }
async getStorySortParameter() { async getStorySortParameter() {