GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-03-21 05:02:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1525 from storybooks/hmr-warning-on-storiesOf

Browse Source 
Add warning when module is missing in storiesOf
This commit is contained in:
igor-dv 2017-07-26 11:46:59 +03:00 committed by GitHub
commit 949f62f08c
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/react/src/client/preview/client_api.js
View File

@ -34,6 +34,13 @@ export default class ClientApi {
throw new Error('Invalid or missing kind provided for stories, should be a string');
}
if (!m) {
// eslint-disable-next-line no-console
console.warn(
`Missing 'module' parameter for story with a kind of '${kind}'. It will break your HMR`
);
}
if (m && m.hot) {
m.hot.dispose(() => {
this._storyStore.removeStoryKind(kind);

4
app/vue/src/client/preview/client_api.js
View File

@ -30,6 +30,10 @@ export default class ClientApi {
throw new Error('Invalid or missing kind provided for stories, should be a string');
}
if(!m) {
console.warn(`Missing 'module' parameter for story with a kind of '${kind}'. It will break your HMR`);
}
if (m && m.hot) {
m.hot.dispose(() => {
this._storyStore.removeStoryKind(kind);

1
lib/ui/package.json
View File

@ -33,7 +33,6 @@
"react-komposer": "^2.0.0",
"react-modal": "^1.7.7",
"react-split-pane": "^0.1.63",
"react-split-pane": "^0.1.65",
"redux": "^3.6.0"
},
"devDependencies": {