GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-03-21 05:02:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Get rid of accidental parts of the commit

Browse Source
This commit is contained in:
Tom Coleman 2020-05-25 19:22:31 +10:00
parent 4807d54ca8
commit 934c8555fa
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/core/src/client/preview/StoryRenderer.tsx
View File

@ -99,7 +99,7 @@ export class StoryRenderer {
if (this.channel) {
this.channel.on(Events.RENDER_CURRENT_STORY, () => this.renderCurrentStory(false));
this.channel.on(Events.STORY_ARGS_UPDATED, () => this.forceReRender());
// this.channel.on(Events.GLOBAL_ARGS_UPDATED, () => this.forceReRender());
this.channel.on(Events.GLOBAL_ARGS_UPDATED, () => this.forceReRender());
this.channel.on(Events.FORCE_RE_RENDER, () => this.forceReRender());
}
}
@ -155,7 +155,6 @@ export class StoryRenderer {
const { forceRender, name } = context;
const { previousMetadata, storyStore } = this;
console.log('renderStoryIfChanged', { previousMetadata, metadata, context });
const storyChanged = !previousMetadata || previousMetadata.id !== metadata.id;
// getDecorated is a function that returns a decorated story function. It'll change whenever the story
@ -165,8 +164,6 @@ export class StoryRenderer {
const viewModeChanged = !previousMetadata || previousMetadata.viewMode !== metadata.viewMode;
const kindChanged = !previousMetadata || previousMetadata.kind !== metadata.kind;
console.log({ forceRender, storyChanged, implementationChanged, viewModeChanged, kindChanged });
// Don't re-render the story if nothing has changed to justify it
if (!forceRender && !storyChanged && !implementationChanged && !viewModeChanged) {
this.channel.emit(Events.STORY_UNCHANGED, {
@ -279,11 +276,9 @@ export class StoryRenderer {
}
renderStory({ context, context: { id, getDecorated } }: { context: RenderContext }) {
console.log('renderStory', context);
if (getDecorated) {
(async () => {
try {
console.log('calling render');
await this.render(context);
this.channel.emit(Events.STORY_RENDERED, id);
} catch (err) {