GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 09:11:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix test to not use different code path

Browse Source
This commit is contained in:
Tom Coleman 2020-05-01 20:21:33 +10:00
parent 11ad35dd26
commit 8a5608f0ad
2 changed files with 43 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
lib/client-api/src/story_store.test.ts
View File

@ -1,4 +1,3 @@
// foo
import createChannel from '@storybook/channel-postmessage';
import { toId } from '@storybook/csf';
import addons, { mockChannel } from '@storybook/addons';
@ -228,13 +227,17 @@ describe('preview.story_store', () => {
describe('globalArgs', () => {
it('is initialized to the value stored in parameters.globalArgs on the first story', () => {
const store = new StoryStore({ channel });
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
store.addGlobalMetadata({
decorators: [],
parameters: {
globalArgs: {
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
},
},
});
addStoryToStore(store, 'a', '1', () => 0);
store.finishConfiguring();
expect(store.getRawStory('a', '1').globalArgs).toEqual({
arg1: 'arg1',
@ -245,16 +248,20 @@ describe('preview.story_store', () => {
it('is initialized to the default values stored in parameters.globalArgsTypes on the first story', () => {
const store = new StoryStore({ channel });
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg1: 'arg1',
arg2: 2,
},
globalArgTypes: {
arg2: { defaultValue: 'arg2' },
arg3: { defaultValue: { complex: { object: ['type'] } } },
store.addGlobalMetadata({
decorators: [],
parameters: {
globalArgs: {
arg1: 'arg1',
arg2: 2,
},
globalArgTypes: {
arg2: { defaultValue: 'arg2' },
arg3: { defaultValue: { complex: { object: ['type'] } } },
},
},
});
addStoryToStore(store, 'a', '1', () => 0);
store.finishConfiguring();
expect(store.getRawStory('a', '1').globalArgs).toEqual({
arg1: 'arg1',
@ -266,30 +273,38 @@ describe('preview.story_store', () => {
it('on HMR it sensibly re-initializes with memory', () => {
const store = new StoryStore({ channel });
addons.setChannel(channel);
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
store.addGlobalMetadata({
decorators: [],
parameters: {
globalArgs: {
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
},
},
});
addStoryToStore(store, 'a', '1', () => 0);
store.finishConfiguring();
// HMR
store.startConfiguring();
store.removeStoryKind('a');
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg2: 2,
// Although we have changed the default there is no way to tell that the user didn't change
// it themselves
arg3: { complex: { object: ['changed'] } },
arg4: 'new',
store.addGlobalMetadata({
decorators: [],
parameters: {
globalArgs: {
arg2: 2,
// Although we have changed the default there is no way to tell that the user didn't change
// it themselves
arg3: { complex: { object: ['changed'] } },
arg4: 'new',
},
},
});
store.finishConfiguring();
expect(store.getRawStory('a', '1').globalArgs).toEqual({
// You cannot remove a global arg in HMR currently
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
arg4: 'new',

4
lib/client-api/src/story_store.ts
View File

@ -55,11 +55,9 @@ const includeStory = (story: StoreItem, options: StoryOptions = { includeDocsOnl
return !isStoryDocsOnly(story.parameters);
};
const inJest = () => process.env.JEST_WORKER_ID !== undefined;
const checkGlobalArgs = (parameters: Parameters) => {
const { globalArgs, globalArgTypes } = parameters;
if ((globalArgs || globalArgTypes) && !inJest()) {
if (globalArgs || globalArgTypes) {
logger.error(
'Global args/argTypes can only be set globally',
JSON.stringify({