GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-08 04:01:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixed failing scenario: If parent is not set to true but some sub toggles are set to true a user should be able to set the parent toggle to true and make all subs true (with intervention)

Browse Source
This commit is contained in:
codebyalex 2019-03-18 20:56:24 -04:00
parent f6aa867c4a
commit 7d2e962966
1 changed files with 25 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
addons/a11y/src/components/Report/HighlightToggle.tsx
View File

@ -171,18 +171,33 @@ class HighlightToggle extends Component<ToggleProps, {}> {
} }
onToggle(): void { onToggle(): void {
if(this.props.isToggledOn){
for (let element of this.props.elementsToHighlight) { for (let element of this.props.elementsToHighlight) {
const targetElement = getTargetElement(element.target[0]); const targetElement = getTargetElement(element.target[0]);
this.higlightRuleLocation(targetElement, !this.props.isToggledOn); if(this.props.highlightedElementsMap.get(targetElement) && this.props.highlightedElementsMap.get(targetElement).isHighlighted){
if (this.props.highlightedElementsMap.get(targetElement)) { this.higlightRuleLocation(targetElement, false);
this.saveElementDataToMap( this.saveElementDataToMap(
targetElement, targetElement,
!this.props.highlightedElementsMap.get(targetElement).isHighlighted, false,
this.props.highlightedElementsMap.get(targetElement).originalOutline, this.props.highlightedElementsMap.get(targetElement).originalOutline,
this.props.type this.props.type
); );
} }
} }
} else {
for (let element of this.props.elementsToHighlight) {
const targetElement = getTargetElement(element.target[0]);
if(this.props.highlightedElementsMap.get(targetElement) && !this.props.highlightedElementsMap.get(targetElement).isHighlighted){
this.higlightRuleLocation(targetElement, true);
this.saveElementDataToMap(
targetElement,
true,
this.props.highlightedElementsMap.get(targetElement).originalOutline,
this.props.type
);
}
}
}
} }
render() { render() {