GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 15:31:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

updated config name, added comment, fixed tests

Browse Source
This commit is contained in:
Gytis Vinclovas 2020-02-16 09:29:32 +02:00
parent 23da639ffc
commit 7753bfac80
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/client-api/src/client_api.test.ts
View File

@ -5,11 +5,14 @@ import ClientApi from './client_api';
import ConfigApi from './config_api';
import StoryStore from './story_store';
const getContext = ({ decorateStory = undefined, disableAddStoryDispose = false } = {}) => {
const getContext = ({
decorateStory = undefined,
noStoryModuleAddMethodHotDispose = false,
} = {}) => {
const channel = mockChannel();
addons.setChannel(channel);
const storyStore = new StoryStore({ channel });
const clientApi = new ClientApi({ storyStore, decorateStory, disableAddStoryDispose });
const clientApi = new ClientApi({ storyStore, decorateStory, noStoryModuleAddMethodHotDispose });
const { clearDecorators } = clientApi;
const configApi = new ConfigApi({ clearDecorators, storyStore, channel, clientApi });
@ -559,20 +562,20 @@ describe('preview.client_api', () => {
storiesOf('kind', module).add('story', jest.fn());
expect(module.hot.dispose.calls.length).toEqual(2);
expect(module.hot.dispose.mock.calls.length).toEqual(2);
});
it('should not bind dispose inside add when disableAddStoryDispose is true', () => {
it('should not call `module.hot.dispose` inside add when noStoryModuleAddMethodHotDispose is true', () => {
const module = new MockModule();
module.hot.dispose = jest.fn();
const {
clientApi: { storiesOf, getStorybook },
} = getContext({ disableAddStoryDispose: true });
} = getContext({ noStoryModuleAddMethodHotDispose: true });
storiesOf('kind', module).add('story', jest.fn());
expect(module.hot.dispose.calls.length).toEqual(1);
expect(module.hot.dispose.mock.calls.length).toEqual(1);
});
});

4
lib/client-api/src/client_api.ts
View File

@ -92,12 +92,12 @@ export default class ClientApi {
constructor({
storyStore,
decorateStory = defaultDecorateStory,
disableAddStoryDispose,
noStoryModuleAddMethodHotDispose,
}: ClientApiParams) {
this._storyStore = storyStore;
this._addons = {};
this._disableAddStoryDispose = disableAddStoryDispose || false;
this._disableAddStoryDispose = noStoryModuleAddMethodHotDispose || false;
this._decorateStory = decorateStory;