GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 20:51:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(server) Fix the serializtion of knobs params back to the server

Browse Source
This commit is contained in:
Jon Palmer 2020-04-12 00:59:50 -04:00
parent 0b940bf216
commit 6f8883b872
No known key found for this signature in database
GPG Key ID: 52E08C6A304553A8
3 changed files with 42 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/server/src/lib/compiler/__testfixtures__/knobs.json
View File

@ -12,7 +12,24 @@
},
"knobs": [
{ "type": "text", "name": "Name", "value": "John Doe", "param": "name"},
{ "type": "number", "name": "Age", "value": 44, "param": "age"}
{ "type": "date", "name": "Birthday", "value": "1960-12-25T00:42:03.600Z", "param": "birthday"},
{ "type": "color", "name": "Favorite Color", "value": "red", "param": "favorite_color"},
{ "type": "boolean", "name": "Acive", "value": true, "param": "active"},
{ "type": "number", "name": "Pets", "value": 2, "param": "pets"},
{ "type": "array", "name": "Sports", "value": ["football", "baseball"], "param": "sports"},
{
"type": "select",
"name": "Favorite Food",
"value": "Ice Cream",
"options": {
"hot_dog": "Hot Dog",
"pizza": "Pizza",
"burgers": "Burgers",
"ice_cream": "Ice Cream"
},
"param": "favorite_food"
},
{ "type": "object", "name": "Other Things", "value": {"hair": "Brown", "eyes": "Blue"}, "param": "other_thinkgs"}
]
}
]

19
app/server/src/lib/compiler/__testfixtures__/knobs.snapshot
View File

@ -18,7 +18,24 @@ export default {
export const Simple = () => {
return {
name: text('Name', 'John Doe'),
age: number('Age', 44, {}),
birthday: new Date(date('Birthday', new Date('1960-12-25T00:42:03.600Z'))).toISOString(),
favorite_color: color('Favorite Color', 'red'),
active: boolean('Acive', true),
pets: number('Pets', 2, {}),
sports: array('Sports', [
'football',
'baseball'
], ',').join(','),
favorite_food: select('Favorite Food', {
hot_dog: 'Hot Dog',
pizza: 'Pizza',
burgers: 'Burgers',
ice_cream: 'Ice Cream'
}, 'Ice Cream'),
other_thinkgs: JSON.stringify(object('Other Things', {
hair: 'Brown',
eyes: 'Blue'
})),
};
};
Simple.story = {

10
app/server/src/lib/compiler/decorators/knobs.ts
View File

@ -27,14 +27,16 @@ function stringifyKnob(knob: StoryKnob) {
return `number('${name}', ${stringifiedValue}, ${stringifyObject(opts, level)})`;
case 'color':
return `color('${name}', ${stringifiedValue})`;
case 'array':
return `array('${name}', ${stringifiedValue}).join(',')`;
case 'array': {
const separator = opts.separator || ',';
return `array('${name}', ${stringifiedValue}, '${separator}').join('${separator}')`;
}
case 'boolean':
return `boolean('${name}', ${stringifiedValue})`;
case 'object':
return `object('${name}', ${stringifiedValue})`;
return `JSON.stringify(object('${name}', ${stringifiedValue}))`;
case 'date':
return `date('${name}', new Date(${stringifiedValue}))`;
return `new Date(date('${name}', new Date(${stringifiedValue}))).toISOString()`;
case 'select':
return `select('${name}', ${stringifyObject(opts.options, level)}, ${stringifiedValue})`;
default: