GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 16:11:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent Interactions panel from picking up exceptions that don't originate from the play function

Browse Source
This commit is contained in:
Gert Hengeveld 2022-06-29 11:22:51 +02:00
parent c530eae065
commit 6e1e04c654
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
addons/interactions/src/Panel.tsx
View File

@ -5,7 +5,7 @@ import {
FORCE_REMOUNT,
IGNORED_EXCEPTION,
STORY_RENDER_PHASE_CHANGED,
STORY_THREW_EXCEPTION,
PLAY_FUNCTION_THREW_EXCEPTION,
} from '@storybook/core-events';
import { EVENTS, Call, CallStates, ControlStates, LogItem } from '@storybook/instrumenter';
@ -105,7 +105,7 @@ export const Panel: React.FC<{ active: boolean }> = (props) => {
setPausedAt(undefined);
if (event.newPhase === 'rendering') setCaughtException(undefined);
},
[STORY_THREW_EXCEPTION]: (e) => {
[PLAY_FUNCTION_THREW_EXCEPTION]: (e) => {
if (e?.message !== IGNORED_EXCEPTION.message) setCaughtException(e);
else setCaughtException(undefined);
},

3
lib/core-events/src/index.ts
View File

@ -29,6 +29,8 @@ enum events {
STORY_THREW_EXCEPTION = 'storyThrewException',
// Emitted at various times during rendering
STORY_RENDER_PHASE_CHANGED = 'storyRenderPhaseChanged',
// Emitted when the play function throws
PLAY_FUNCTION_THREW_EXCEPTION = 'playFunctionThrewException',
// Tell the story store to update (a subset of) a stories arg values
UPDATE_STORY_ARGS = 'updateStoryArgs',
// The values of a stories args just changed
@ -79,6 +81,7 @@ export const {
STORY_ERRORED,
STORY_THREW_EXCEPTION,
STORY_RENDER_PHASE_CHANGED,
PLAY_FUNCTION_THREW_EXCEPTION,
UPDATE_STORY_ARGS,
STORY_ARGS_UPDATED,
RESET_STORY_ARGS,

4
lib/preview-web/src/StoryRender.ts
View File

@ -18,7 +18,7 @@ import { logger } from '@storybook/client-logger';
import {
STORY_RENDER_PHASE_CHANGED,
STORY_RENDERED,
STORY_THREW_EXCEPTION,
PLAY_FUNCTION_THREW_EXCEPTION,
} from '@storybook/core-events';
const { AbortController } = global;
@ -240,7 +240,7 @@ export class StoryRender<TFramework extends AnyFramework> implements Render<TFra
} catch (error) {
logger.error(error);
await this.runPhase(abortSignal, 'errored', async () => {
this.channel.emit(STORY_THREW_EXCEPTION, serializeError(error));
this.channel.emit(PLAY_FUNCTION_THREW_EXCEPTION, serializeError(error));
});
}
this.disableKeyListeners = false;