GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-07 04:01:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Core: Fix process.env assignment

Browse Source
This commit is contained in:
Michael Shilman 2022-01-08 17:25:58 +08:00
parent cc14131e43
commit 68e8f1c9d6
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
examples/react-ts/.env Normal file
View File

@ -0,0 +1 @@
FOO=bar

7
examples/react-ts/src/button.stories.tsx
View File

@ -27,6 +27,13 @@ export const StoryNoRender = {
args: { label: 'magic!' }, args: { label: 'magic!' },
}; };
export const ProcessEnv = {
args: { label: process.env.FOO },
play: () => {
process.env.BAZ = 'moo';
},
};
export const StoryWithPlay = { export const StoryWithPlay = {
args: { label: 'play' }, args: { label: 'play' },
play: () => { play: () => {

8
lib/core-common/src/utils/envs.ts
View File

@ -59,8 +59,12 @@ export const stringifyProcessEnvs = (raw: Record<string, string>): Record<string
'process.env.XSTORYBOOK_EXAMPLE_APP': '""', 'process.env.XSTORYBOOK_EXAMPLE_APP': '""',
} }
); );
// support destructuring like // FIXME: something like this is necessary to support destructuring like:
//
// const { foo } = process.env; // const { foo } = process.env;
envs['process.env'] = JSON.stringify(raw); //
// However, it also means that process.env.foo = 'bar' will fail, so removing this:
//
// envs['process.env'] = JSON.stringify(raw);
return envs; return envs;
}; };