GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-07 07:21:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #26202 from storybookjs/norbert/remove-deprecation-manager-api-types

Browse Source 
Maintenance: Remove deprecation of `manager-api`'s `types` export
This commit is contained in:
Norbert de Langen 2024-02-27 12:13:42 +01:00 committed by GitHub
commit 670c58c983
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
code/lib/manager-api/src/index.tsx
View File

@ -517,11 +517,8 @@ export function useArgTypes(): ArgTypes {
export { addons } from './lib/addons'; export { addons } from './lib/addons';
/** // We need to rename this so it's not compiled to a straight re-export
* We need to rename this so it's not compiled to a straight re-export // Our globalization plugin can't handle an import and export of the same name in different lines
* Our globalization plugin can't handle an import and export of the same name in different lines
* @deprecated
*/
const typesX = types; const typesX = types;
export { typesX as types }; export { typesX as types };

7
code/lib/types/src/modules/addons.ts
View File

@ -358,7 +358,12 @@ export interface Addon_BaseType {
* This is called as a function, so if you want to use hooks, * This is called as a function, so if you want to use hooks,
* your function needs to return a JSX.Element within which components are rendered * your function needs to return a JSX.Element within which components are rendered
*/ */
render: (renderOptions: Partial<Addon_RenderOptions>) => ReactElement<any, any> | null; render: (props: Partial<Addon_RenderOptions>) => ReturnType<FC<Partial<Addon_RenderOptions>>>;
// TODO: for Storybook 9 I'd like to change this to be:
// render: FC<Partial<Addon_RenderOptions>>;
// This would bring it in line with how every other addon is set up.
// We'd need to change how the render function is called in the manager:
// https://github.com/storybookjs/storybook/blob/4e6fc0dde0842841d99cb3cf5148ca293a950301/code/ui/manager/src/components/preview/Preview.tsx#L105
/** /**
* @unstable * @unstable
*/ */