GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 18:41:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Addon-knobs: Fix select options types to allow string[] and null (#7356)

Browse Source 
Addon-knobs: Fix select options types to allow string[] and null
This commit is contained in:
Michael Shilman 2019-07-10 10:27:01 +08:00 committed by GitHub
commit 5f6ce01af5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
addons/knobs/src/components/types/Select.tsx
View File

@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import { Form } from '@storybook/components';
type SelectTypeKnobValue = string;
export type SelectTypeKnobValue = string | number | null | undefined;
export interface SelectTypeKnob {
name: string;
@ -11,9 +11,9 @@ export interface SelectTypeKnob {
options: SelectTypeOptionsProp;
}
export interface SelectTypeOptionsProp {
[key: string]: SelectTypeKnobValue;
}
export type SelectTypeOptionsProp =
| Record<string, SelectTypeKnobValue>
| NonNullable<SelectTypeKnobValue>[];
export interface SelectTypeProps {
knob: SelectTypeKnob;

2
addons/knobs/src/components/types/index.ts
View File

@ -31,7 +31,7 @@ export { NumberTypeKnob, NumberTypeKnobOptions } from './Number';
export { ColorTypeKnob } from './Color';
export { BooleanTypeKnob } from './Boolean';
export { ObjectTypeKnob } from './Object';
export { SelectTypeKnob, SelectTypeOptionsProp } from './Select';
export { SelectTypeKnob, SelectTypeOptionsProp, SelectTypeKnobValue } from './Select';
export { RadiosTypeKnob, RadiosTypeOptionsProp } from './Radio';
export { ArrayTypeKnob } from './Array';
export { DateTypeKnob } from './Date';

3
addons/knobs/src/index.ts
View File

@ -7,6 +7,7 @@ import {
ButtonTypeOnClickProp,
RadiosTypeOptionsProp,
SelectTypeOptionsProp,
SelectTypeKnobValue,
OptionsTypeOptionsProp,
OptionsKnobOptions,
} from './components/types';
@ -63,7 +64,7 @@ export function object<T>(name: string, value: T, groupId?: string) {
export function select(
name: string,
options: SelectTypeOptionsProp,
value: string,
value: SelectTypeKnobValue,
groupId?: string
) {
return manager.knob(name, { type: 'select', selectV2: true, options, value, groupId });