From b1ca049c6b039c18462d78ff4e84d163d5354233 Mon Sep 17 00:00:00 2001 From: Hypnosphi Date: Sat, 21 Apr 2018 23:27:11 +0300 Subject: [PATCH] Upgrade sass-loader to 7.0.1 & stop bringing node-sass bin to each user --- app/angular/package.json | 3 +- docs/src/pages/basics/guide-angular/index.md | 2 ++ yarn.lock | 34 ++------------------ 3 files changed, 6 insertions(+), 33 deletions(-) diff --git a/app/angular/package.json b/app/angular/package.json index c291a08e65d..3035d37c536 100644 --- a/app/angular/package.json +++ b/app/angular/package.json @@ -44,11 +44,10 @@ "html-loader": "^0.5.5", "html-webpack-plugin": "^3.2.0", "markdown-loader": "^2.0.2", - "node-sass": "^4.8.3", "raw-loader": "^0.5.1", "react": "^16.3.2", "react-dom": "^16.3.2", - "sass-loader": "^6.0.7", + "sass-loader": "^7.0.1", "ts-loader": "^4.2.0", "webpack": "^4.6.0", "webpack-hot-middleware": "^2.22.1", diff --git a/docs/src/pages/basics/guide-angular/index.md b/docs/src/pages/basics/guide-angular/index.md index d0f7906de18..51cc57a82c6 100644 --- a/docs/src/pages/basics/guide-angular/index.md +++ b/docs/src/pages/basics/guide-angular/index.md @@ -181,3 +181,5 @@ You may need to exclude your stories from being compiled when running your angul ] } ``` + +If you're using scss for styling, you need to have `node-sass` dependency installed on your side (directly or via `@angular/cli`). diff --git a/yarn.lock b/yarn.lock index 0ed8e856174..2e9825607b8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10966,10 +10966,6 @@ mute-stream@0.0.7, mute-stream@~0.0.4: version "0.0.7" resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-0.0.7.tgz#3075ce93bc21b8fab43e1bc4da7e8115ed1e7bab" -nan@^2.10.0: - version "2.10.0" - resolved "https://registry.yarnpkg.com/nan/-/nan-2.10.0.tgz#96d0cd610ebd58d4b4de9cc0c6828cda99c7548f" - nan@^2.3.0, nan@^2.3.2: version "2.8.0" resolved "https://registry.yarnpkg.com/nan/-/nan-2.8.0.tgz#ed715f3fe9de02b57a5e6252d90a96675e1f085a" @@ -11216,30 +11212,6 @@ node-sass@^4.7.2: stdout-stream "^1.4.0" "true-case-path" "^1.0.2" -node-sass@^4.8.3: - version "4.8.3" - resolved "https://registry.yarnpkg.com/node-sass/-/node-sass-4.8.3.tgz#d077cc20a08ac06f661ca44fb6f19cd2ed41debb" - dependencies: - async-foreach "^0.1.3" - chalk "^1.1.1" - cross-spawn "^3.0.0" - gaze "^1.0.0" - get-stdin "^4.0.1" - glob "^7.0.3" - in-publish "^2.0.0" - lodash.assign "^4.2.0" - lodash.clonedeep "^4.3.2" - lodash.mergewith "^4.6.0" - meow "^3.7.0" - mkdirp "^0.5.1" - nan "^2.10.0" - node-gyp "^3.3.1" - npmlog "^4.0.0" - request "~2.79.0" - sass-graph "^2.2.4" - stdout-stream "^1.4.0" - "true-case-path" "^1.0.2" - node-status-codes@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/node-status-codes/-/node-status-codes-1.0.0.tgz#5ae5541d024645d32a58fcddc9ceecea7ae3ac2f" @@ -14556,9 +14528,9 @@ sass-loader@^6.0.6: lodash.tail "^4.1.1" pify "^3.0.0" -sass-loader@^6.0.7: - version "6.0.7" - resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-6.0.7.tgz#dd2fdb3e7eeff4a53f35ba6ac408715488353d00" +sass-loader@^7.0.1: + version "7.0.1" + resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-7.0.1.tgz#fd937259ccba3a9cfe0d5f8a98746d48adfcc261" dependencies: clone-deep "^2.0.1" loader-utils "^1.0.1"