GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 06:41:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7470 from storybookjs/ondevice-knobs-group-id-fix

Browse Source 
React-native: On-device knobs fixes
This commit is contained in:
Michael Shilman 2019-07-18 18:22:13 +08:00 committed by GitHub
commit 56c81ba53b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
addons/ondevice-knobs/src/GroupTabs.js
View File

@ -14,6 +14,7 @@ class GroupTabs extends Component {
return (
<TouchableOpacity
style={{
marginTop: 5,
marginRight: 15,
paddingBottom: 10,
}}

3
addons/ondevice-knobs/src/PropField.js
View File

@ -19,7 +19,7 @@ const PropField = ({ onChange, onPress, knob }) => {
fontWeight: 'bold',
}}
>
{`${knob.name}`}
{`${knob.label || knob.name}`}
</Text>
) : null}
<InputType knob={knob} onChange={onChange} onPress={onPress} />
@ -30,6 +30,7 @@ const PropField = ({ onChange, onPress, knob }) => {
PropField.propTypes = {
knob: PropTypes.shape({
name: PropTypes.string,
label: PropTypes.string,
value: PropTypes.any,
hideLabel: PropTypes.bool,
type: PropTypes.oneOf([

5
addons/ondevice-knobs/src/panel.js
View File

@ -118,6 +118,11 @@ export default class Panel extends React.Component {
render: () => <Text id={DEFAULT_GROUP_ID}>{DEFAULT_GROUP_ID}</Text>,
title: DEFAULT_GROUP_ID,
};
if (groupId === DEFAULT_GROUP_ID) {
knobsArray = knobsArray.filter(key => !knobs[key].groupId);
}
if (groupId !== DEFAULT_GROUP_ID) {
knobsArray = knobsArray.filter(key => knobs[key].groupId === groupId);
}