GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 09:51:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use import paths for errors, and slash them

Browse Source
This commit is contained in:
Tom Coleman 2023-02-20 21:46:50 +11:00
parent 048ef7fe89
commit 53747a8931
4 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
code/lib/core-server/src/utils/IndexingError.ts
View File

@ -1,3 +1,5 @@
import slash from 'slash';
export class IndexingError extends Error {
importPaths: string[];
@ -12,10 +14,10 @@ export class IndexingError extends Error {
pathsString() {
if (this.importPaths.length === 1) {
return `${this.importPaths[0]}`;
return `${slash(this.importPaths[0])}`;
}
return `${this.importPaths}`;
return `${this.importPaths.map(slash).join(',')}`;
}
toString() {

2
code/lib/core-server/src/utils/StoryIndexGenerator.test.ts
View File

@ -958,7 +958,7 @@ describe('StoryIndexGenerator', () => {
);
await generator.initialize();
await expect(() => generator.getIndex()).rejects.toThrowErrorMatchingInlineSnapshot(
`"Unable to index src/docs2/MetaOf.mdx"`
`"Unable to index ./src/docs2/MetaOf.mdx"`
);
});
});

6
code/lib/core-server/src/utils/StoryIndexGenerator.ts
View File

@ -167,7 +167,11 @@ export class StoryIndexGenerator {
try {
entry[absolutePath] = await updater(specifier, absolutePath, entry[absolutePath]);
} catch (err) {
const relativePath = path.relative(this.options.workingDir, absolutePath);
const relativePath = `.${path.sep}${path.relative(
this.options.workingDir,
absolutePath
)}`;
entry[absolutePath] = {
type: 'error',
err: new IndexingError(err.message, [relativePath], err.stack),

10
code/lib/core-server/src/utils/stories-json.test.ts
View File

@ -655,11 +655,11 @@ describe('useStoriesJson', () => {
expect(send).toHaveBeenCalledTimes(1);
expect(send.mock.calls[0][0]).toMatchInlineSnapshot(`
"Unable to index files:
- src/docs2/MetaOf.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- src/docs2/NoTitle.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- src/docs2/SecondMetaOf.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- src/docs2/Template.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- src/docs2/Title.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`."
- ./src/docs2/MetaOf.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- ./src/docs2/NoTitle.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- ./src/docs2/SecondMetaOf.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- ./src/docs2/Template.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`.
- ./src/docs2/Title.mdx: You cannot use \`.mdx\` files without using \`storyStoreV7\`."
`);
});