GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 19:11:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19642 from storybookjs/tom/sb-883-support-tags-in-storiesof-via-parameters

Browse Source 
Allow setting tags in storiesOf via parameters.
This commit is contained in:
Tom Coleman 2022-10-27 22:59:54 +11:00 committed by GitHub
commit 527bea0e08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
code/lib/client-api/src/ClientApi.ts
View File

@ -360,7 +360,7 @@ Read more here: https://github.com/storybookjs/storybook/blob/master/MIGRATION.m
return api;
};
api.addParameters = ({ component, args, argTypes, ...parameters }: Parameters) => {
api.addParameters = ({ component, args, argTypes, tags, ...parameters }: Parameters) => {
if (hasAdded)
throw new Error(`You cannot add parameters after the first story for a kind.
Read more here: https://github.com/storybookjs/storybook/blob/master/MIGRATION.md#can-no-longer-add-decoratorsparameters-after-stories`);
@ -369,6 +369,7 @@ Read more here: https://github.com/storybookjs/storybook/blob/master/MIGRATION.m
if (component) meta.component = component;
if (args) meta.args = { ...meta.args, ...args };
if (argTypes) meta.argTypes = { ...meta.argTypes, ...argTypes };
if (tags) meta.tags = tags;
return api;
};

18
code/lib/core-client/src/preview/start.test.ts
View File

@ -1121,7 +1121,7 @@ describe('start', () => {
global.DOCS_OPTIONS = { enabled: true, docsPage: true, defaultName: 'Docs' };
});
it('adds stories for each component', async () => {
it('adds stories for each component with docsPage tag', async () => {
const renderToDOM = jest.fn();
const { configure, clientApi } = start(renderToDOM);
@ -1133,6 +1133,7 @@ describe('start', () => {
clientApi
.storiesOf('Component B', { id: 'file2' } as NodeModule)
.addParameters({ tags: ['docsPage'] })
.add('Story Three', jest.fn());
return [componentCExports];
@ -1183,6 +1184,20 @@ describe('start', () => {
"title": "Component A",
"type": "story",
},
"component-b--docs": Object {
"componentId": "component-b",
"id": "component-b--docs",
"importPath": "file2",
"name": "Docs",
"standalone": false,
"storiesImports": Array [],
"tags": Array [
"docsPage",
"docs",
],
"title": "Component B",
"type": "docs",
},
"component-b--story-three": Object {
"argTypes": Object {},
"args": Object {},
@ -1198,6 +1213,7 @@ describe('start', () => {
"framework": "test",
},
"tags": Array [
"docsPage",
"story",
],
"title": "Component B",