GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 19:21:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16462 from storybookjs/16430-fix-initial-story-interactions

Browse Source 
Interactions: Do not cleanup state when loading initial story
This commit is contained in:
Michael Shilman 2021-10-25 20:20:32 +08:00 committed by GitHub
commit 49323212de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/instrumenter/src/instrumenter.test.ts
View File

@ -317,6 +317,7 @@ describe('Instrumenter', () => {
});
it('clears state when switching stories', () => {
addons.getChannel().emit(SET_CURRENT_STORY); // initialization
instrumenter.state = {
'kind--story': {
isDebugging: false,

9
lib/instrumenter/src/instrumenter.ts
View File

@ -102,6 +102,8 @@ const getRetainedState = (state: State, isDebugging = false) => {
export class Instrumenter {
channel: Channel;
initialized = false;
// State is tracked per story to deal with multiple stories on the same canvas (i.e. docs mode)
state: Record<StoryId, State>;
@ -144,8 +146,11 @@ export class Instrumenter {
}
});
// Trash non-retained state and clear the log when switching stories.
this.channel.on(SET_CURRENT_STORY, this.cleanup.bind(this));
// Trash non-retained state and clear the log when switching stories, but not on initial boot.
this.channel.on(SET_CURRENT_STORY, () => {
if (this.initialized) this.cleanup();
else this.initialized = true;
});
const start = ({ storyId, playUntil }: { storyId: string; playUntil?: Call['id'] }) => {
if (!this.getState(storyId).isDebugging) {